Skip to content

Deprecate custom select_sql and delete_sql configuration #94

Description

@nertzy

FixtureBuilder exposes select_sql and delete_sql configuration for replacing its default table queries with SQL string templates. Internally, FixtureBuilder must interpolate an adapter-quoted table name into those templates.

The original motivating example from #32 was:

fbuilder.select_sql =
  "SELECT * FROM %{table} ORDER BY %{table}.*"

Arel can now construct the default select and delete queries—including that ordering expression—without SQL string interpolation. Public GitHub code search does not currently show any applications overriding either setting.

We plan to deprecate select_sql and delete_sql in FixtureBuilder 0.6. If no current use cases surface, we will remove them in a future minor release and construct these queries through Arel instead.

If your application overrides either setting, please comment with the query and the reason for the customization. That will help determine whether the use case should be supported through a different API.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions