test: naprawa 16 testów rozjechanych z kodem po refaktorach

Wszystkie wynikały z tego, że kod produkcyjny był refaktorowany bez
aktualizacji testów — żadnej realnej usterki aplikacji.

image_generator (10): prywatne helpery zmieniły nazwy przy przepisaniu
generatora. Testy asertujące bezpośrednio na nich usunięte (decyzja GK:
testujemy zachowanie, nie implementację) — _find_speaker_by_id,
_get_speaker_avatar_download/_from_cache, _create_circular_mask; ten
ostatni i tak duplikował test_apply_circular_mask. Testy publicznego API
i face centeringu przepięte z _get_speaker_avatar na _avatar. Trzy testy
językowe przekazywały pustą listę prelegentów do meetupu z prelekcją,
przez co _find_speaker leciał StopIteration — dostają teraz prelegenta.

models + integration (4): location_name i formatted_date przestały być
property, są metodami z parametrem language. Dodatkowo lokalizacja daty
(nazwa dnia, PL/EN) przeniosła się do image_generator._resolve_date_parts,
więc test_models asertuje dziś faktyczny kontrakt modelu ("2024.06.27 18:00")
zamiast nieistniejącego "CZWARTEK". Oczekiwanie w test_integration miało
też zabłąkany cudzysłów i nieaktualne "budynek".

cli (1): generate_all_meetups woła też get_speakers_for_meetup
i _fetch_talks_data — fixture ich nie stubował, więc goły Mock trafiał
do create_meetup_file i wywalał się na iteracji.

pytest: 95 passed, 0 failed (było 83 passed / 16 failed). ruff czysty.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Grzegorz Kocjan

tests/test_cli.py

@@ -1,12 +1,22 @@
 from datetime import date
+from io import BytesIO
 from pathlib import Path
 from unittest.mock import Mock, patch
 
 import pytest
+from PIL import Image
 from typer.testing import CliRunner
 
 from pyldz.main import app
-from pyldz.models import Language, Meetup, MeetupStatus, MultiLanguage, Talk
+from pyldz.models import (
+    File,
+    Language,
+    Meetup,
+    MeetupStatus,
+    MultiLanguage,
+    Speaker,
+    Talk,
+)
 
 
 @pytest.fixture
@@ -27,7 +37,20 @@ def mock_config(tmp_path):
 
 
 @pytest.fixture
-def mock_repository():
+def sample_speaker():
+    buf = BytesIO()
+    Image.new("RGBA", (300, 300), (255, 0, 0, 255)).save(buf, format="PNG")
+    return Speaker(
+        id="john-doe",
+        name="John Doe",
+        bio="A developer",
+        avatar=File(name="avatar.png", content=buf.getvalue()),
+        social_links=[],
+    )
+
+
+@pytest.fixture
+def mock_repository(sample_speaker):
     with patch("pyldz.main.GoogleSheetsRepository") as mock_repo_class:
         repo_instance = Mock()
         mock_repo_class.return_value = repo_instance
@@ -60,6 +83,11 @@ def mock_repository():
         )
 
         repo_instance.get_all_enabled_meetups.return_value = [sample_meetup]
+        # HugoMeetupGenerator.generate_all_meetups sięga też po prelegentów
+        # (get_speakers_for_meetup + _fetch_talks_data) — bez tych stubów
+        # goły Mock trafia do create_meetup_file i wywala się na iteracji.
+        repo_instance._fetch_talks_data.return_value = []
+        repo_instance.get_speakers_for_meetup.return_value = [sample_speaker]
         yield repo_instance
 
 

tests/test_descriptions.py

@@ -182,7 +182,9 @@ def test_generate_meetup_com(sample_meetup_two_talks, sample_speaker, tmp_path):
     assert "Learn clean architecture." in description
     assert SocialMediaLinks.DISCORD in description
     assert "Cześć!" not in description
-    assert "Podczas spotkania odbędą się niezwykle ciekawe prezentacje:" not in description
+    assert (
+        "Podczas spotkania odbędą się niezwykle ciekawe prezentacje:" not in description
+    )
     assert "Zaproś innych!" not in description
     # Talks unified format: no numbering, em-dash separator
     assert "Clean Architecture — John Doe" in description
@@ -197,7 +199,9 @@ def test_generate_meetup_com_to_be_announced(
     sample_meetup_tba, sample_speaker, tmp_path
 ):
     """Test meetup.com description generation for a meetup without talks."""
-    generator = MeetupDescriptionGenerator(sample_meetup_tba, [sample_speaker], tmp_path)
+    generator = MeetupDescriptionGenerator(
+        sample_meetup_tba, [sample_speaker], tmp_path
+    )
 
     description = generator.generate_meetup_com()
 
@@ -231,7 +235,9 @@ def test_generate_youtube_live(sample_meetup_two_talks, sample_speaker, tmp_path
 
 def test_youtube_live_agenda_tba_meetup(sample_meetup_tba, sample_speaker, tmp_path):
     """TBA meetups keep generic agenda slots in YouTube live description."""
-    generator = MeetupDescriptionGenerator(sample_meetup_tba, [sample_speaker], tmp_path)
+    generator = MeetupDescriptionGenerator(
+        sample_meetup_tba, [sample_speaker], tmp_path
+    )
 
     description = generator.generate_youtube_live()
 

tests/test_face_centering.py

@@ -62,9 +62,7 @@ def test_detect_and_center_square_multiple_faces(monkeypatch, sample_rect_image)
 
 
 class TestImageGeneratorFaceCentering:
-    def test_get_speaker_avatar_uses_centered_square_and_caching(
-        self, tmp_path, monkeypatch
-    ):
+    def test_avatar_uses_centered_square_and_caching(self, tmp_path, monkeypatch):
         # Prepare assets dir with minimal structure
         assets_dir = tmp_path / "assets"
         (assets_dir / "images" / "avatars").mkdir(parents=True)
@@ -105,7 +103,7 @@ def fake_center(img: Image.Image) -> Image.Image:
 
         monkeypatch.setattr(face_centering, "detect_and_center_square", fake_center)
 
-        result = generator._get_speaker_avatar(speaker, (300, 300))
+        result = generator._avatar(speaker, (300, 300))
 
         assert result is not None
         assert result.size == (300, 300)
@@ -114,9 +112,7 @@ def fake_center(img: Image.Image) -> Image.Image:
         processed_cache = generator.cache_dir / f"{speaker.id}.png"
         assert processed_cache.exists()
 
-    def test_get_speaker_avatar_no_face_detected_uses_fallback(
-        self, tmp_path, monkeypatch
-    ):
+    def test_avatar_no_face_detected_uses_fallback(self, tmp_path, monkeypatch):
         """Test that when face detection fails, avatar is used without face centering."""
         # Prepare assets dir with minimal structure
         assets_dir = tmp_path / "assets"
@@ -160,7 +156,7 @@ def fake_center_no_face(img: Image.Image) -> Image.Image:
         )
 
         # Should not raise, should return the avatar without face centering
-        result = generator._get_speaker_avatar(speaker, (300, 300))
+        result = generator._avatar(speaker, (300, 300))
 
         assert result is not None
         assert result.size == (300, 300)

tests/test_image_generator.py

@@ -4,7 +4,7 @@
 import pytest
 from PIL import Image
 
-from pyldz.image_generator import ImageGenerationError, MeetupImageGenerator
+from pyldz.image_generator import MeetupImageGenerator
 from pyldz.models import File, Language, Meetup, MultiLanguage, Speaker, Talk
 
 
@@ -169,8 +169,8 @@ def test_generate_featured_image_solo(
     generator = MeetupImageGenerator(temp_assets_dir)
     output_path = tmp_path / "featured.png"
 
-    with patch.object(generator, "_get_speaker_avatar") as mock_get_avatar:
-        mock_get_avatar.return_value = Image.new("RGBA", (300, 300), (255, 0, 0, 255))
+    with patch.object(generator, "_avatar") as mock_avatar:
+        mock_avatar.return_value = Image.new("RGBA", (300, 300), (255, 0, 0, 255))
 
         result = generator.generate_featured_image(
             sample_meetup, [sample_speaker], output_path
@@ -186,8 +186,8 @@ def test_generate_featured_image_duo(
     generator = MeetupImageGenerator(temp_assets_dir)
     output_path = tmp_path / "featured.png"
 
-    with patch.object(generator, "_get_speaker_avatar") as mock_get_avatar:
-        mock_get_avatar.return_value = Image.new("RGBA", (240, 240), (255, 0, 0, 255))
+    with patch.object(generator, "_avatar") as mock_avatar:
+        mock_avatar.return_value = Image.new("RGBA", (240, 240), (255, 0, 0, 255))
 
         result = generator.generate_featured_image(
             sample_duo_meetup, sample_speakers, output_path
@@ -197,61 +197,6 @@ def test_generate_featured_image_duo(
     assert output_path.exists()
 
 
-def test_find_speaker_by_id(temp_assets_dir, sample_speakers):
-    """Test finding speaker by ID."""
-    generator = MeetupImageGenerator(temp_assets_dir)
-
-    speaker = generator._find_speaker_by_id(sample_speakers, "john-doe")
-    assert speaker is not None
-    assert speaker.name == "John Doe"
-
-    speaker = generator._find_speaker_by_id(sample_speakers, "nonexistent")
-    assert speaker is None
-
-
-def test_get_speaker_avatar_download(temp_assets_dir):
-    generator = MeetupImageGenerator(temp_assets_dir)
-
-    # Create a test image in memory
-    test_image = Image.new("RGB", (100, 100), (255, 0, 0))
-    from io import BytesIO
-
-    img_bytes = BytesIO()
-    test_image.save(img_bytes, format="PNG")
-    img_bytes.seek(0)
-
-    speaker = Speaker(
-        id="john-doe",
-        name="John Doe",
-        bio="A developer",
-        avatar=File(name="avatar.png", content=img_bytes.getvalue()),
-        social_links=[],
-    )
-
-    avatar = generator._get_speaker_avatar(speaker, (50, 50))
-
-    assert avatar is not None
-    assert avatar.size == (50, 50)
-
-    # Check that avatar was cached
-    cache_file = generator.cache_dir / f"{speaker.id}.png"
-    assert cache_file.exists()
-
-
-def test_get_speaker_avatar_from_cache(temp_assets_dir, sample_speaker):
-    generator = MeetupImageGenerator(temp_assets_dir)
-
-    # Create cached avatar
-    cache_file = generator.cache_dir / f"{sample_speaker.id}.png"
-    test_image = Image.new("RGBA", (100, 100), (0, 255, 0, 255))
-    test_image.save(cache_file)
-
-    avatar = generator._get_speaker_avatar(sample_speaker, (50, 50))
-
-    assert avatar is not None
-    assert avatar.size == (50, 50)
-
-
 def test_apply_circular_mask(temp_assets_dir):
     generator = MeetupImageGenerator(temp_assets_dir)
 
@@ -274,59 +219,61 @@ def test_apply_circular_mask_missing_mask_file(temp_assets_dir):
     assert masked.mode == "RGBA"
 
 
-def test_create_circular_mask(temp_assets_dir):
-    generator = MeetupImageGenerator(temp_assets_dir)
-
-    test_image = Image.new("RGBA", (100, 100), (255, 0, 0, 255))
-    masked = generator._create_circular_mask(test_image)
-
-    assert masked.size == test_image.size
-    assert masked.mode == "RGBA"
-
-
-def test_generate_featured_image_polish_language(temp_assets_dir, sample_meetup):
+def test_generate_featured_image_polish_language(
+    temp_assets_dir, sample_meetup, sample_speaker
+):
     """Test generating featured image in Polish language."""
     generator = MeetupImageGenerator(temp_assets_dir)
     output_path = temp_assets_dir / "featured-pl.png"
 
     # Generate image in Polish
-    result = generator.generate_featured_image(
-        sample_meetup, [], output_path, Language.PL
-    )
+    with patch.object(generator, "_avatar") as mock_avatar:
+        mock_avatar.return_value = Image.new("RGBA", (300, 300), (255, 0, 0, 255))
+        result = generator.generate_featured_image(
+            sample_meetup, [sample_speaker], output_path, Language.PL
+        )
 
     assert result == output_path
     assert output_path.exists()
     assert output_path.suffix == ".png"
 
 
-def test_generate_featured_image_english_language(temp_assets_dir, sample_meetup):
+def test_generate_featured_image_english_language(
+    temp_assets_dir, sample_meetup, sample_speaker
+):
     """Test generating featured image in English language."""
     generator = MeetupImageGenerator(temp_assets_dir)
     output_path = temp_assets_dir / "featured-en.png"
 
     # Generate image in English
-    result = generator.generate_featured_image(
-        sample_meetup, [], output_path, Language.EN
-    )
+    with patch.object(generator, "_avatar") as mock_avatar:
+        mock_avatar.return_value = Image.new("RGBA", (300, 300), (255, 0, 0, 255))
+        result = generator.generate_featured_image(
+            sample_meetup, [sample_speaker], output_path, Language.EN
+        )
 
     assert result == output_path
     assert output_path.exists()
     assert output_path.suffix == ".png"
 
 
-def test_generate_featured_image_both_languages(temp_assets_dir, sample_meetup):
+def test_generate_featured_image_both_languages(
+    temp_assets_dir, sample_meetup, sample_speaker
+):
     """Test generating featured images in both languages."""
     generator = MeetupImageGenerator(temp_assets_dir)
     pl_path = temp_assets_dir / "featured-pl.png"
     en_path = temp_assets_dir / "featured-en.png"
 
     # Generate both versions
-    pl_result = generator.generate_featured_image(
-        sample_meetup, [], pl_path, Language.PL
-    )
-    en_result = generator.generate_featured_image(
-        sample_meetup, [], en_path, Language.EN
-    )
+    with patch.object(generator, "_avatar") as mock_avatar:
+        mock_avatar.return_value = Image.new("RGBA", (300, 300), (255, 0, 0, 255))
+        pl_result = generator.generate_featured_image(
+            sample_meetup, [sample_speaker], pl_path, Language.PL
+        )
+        en_result = generator.generate_featured_image(
+            sample_meetup, [sample_speaker], en_path, Language.EN
+        )
 
     assert pl_result.exists()
     assert en_result.exists()

tests/test_integration.py

@@ -12,7 +12,6 @@
     LocationRepository,
     MeetupStatus,
     MultiLanguage,
-    Speaker,
     _MeetupRow,
     _TalkRow,
 )
@@ -298,7 +297,9 @@ def test_complete_data_flow_single_meetup(
     assert meetup.title == "Meetup #58"
     assert meetup.date == date(2025, 5, 28)
     assert meetup.time == "18:00"
-    assert meetup.location_name == 'IndieBI, Piotrkowska 157A, budynek Hi Piotrkowska"'
+    assert (
+        meetup.location_name(Language.PL) == "IndieBI, Piotrkowska 157A, Hi Piotrkowska"
+    )
     # featured field removed in current model
     assert meetup.status == MeetupStatus.PUBLISHED
     assert (
@@ -689,7 +690,7 @@ def test_model_integration_and_validation():
     assert meetup.talks[0].speaker_id == speaker.id
     assert meetup.talks[0].language == Language.EN
     assert speaker.name == "John Doe"
-    assert meetup.location_name == "Test Venue EN"
+    assert meetup.location_name(Language.EN) == "Test Venue EN"
 
 
 def test_speaker_with_missing_photo_url_uses_fallback():

tests/test_models.py

@@ -200,10 +200,9 @@ def test_meetup_formatted_date_polish():
         language=Language.PL,
     )
 
-    formatted = meetup.formatted_date
-    assert "CZWARTEK" in formatted
-    assert "27.06.2024" in formatted
-    assert "18:00" in formatted
+    # Nazwa dnia i lokalizacja PL/EN przeniosły się do
+    # MeetupImageGenerator._resolve_date_parts; model zwraca surowy stempel.
+    assert meetup.formatted_date(Language.PL) == "2024.06.27 18:00"
 
 
 def test_meetup_formatted_date_english():
@@ -218,9 +217,5 @@ def test_meetup_formatted_date_english():
         language=Language.EN,
     )
 
-    formatted = meetup.formatted_date
-    assert "THURSDAY" in formatted
-    assert "June" in formatted
-    assert "27" in formatted
-    assert "2024" in formatted
-    assert "18:00" in formatted
+    # Stempel jest niezależny od języka — patrz test powyżej.
+    assert meetup.formatted_date(Language.EN) == "2024.06.27 18:00"