Commit bd4780a
chore: log the per-object fallback loads instead of swallowing them silently
`_batch_load_objects()` and its async twin fall back to loading objects one at
a time when the calendar-multiget REPORT fails. The fallback swallowed every
per-object error with a bare `except Exception: pass`, so a server that failed
both the batch and the individual load left one error-level line about the
batch and no trace at all of what happened to each object.
github-code-quality flagged both handlers - an empty except with neither a log
nor an explanatory comment - on
#694
The swallowing itself is the documented contract: the caller filters on
is_loaded() afterwards, and one unfetchable object must not abort the rest. So
the behaviour is unchanged and both handlers now say that in a comment, plus a
debug line naming the URL. Debug rather than warning on purpose - the batch
failure above is already logged at error level, and a large batch would
otherwise emit a wall of warnings for a condition the caller is expected to
handle. The docstring said "silently swallowing"; it now says what actually
happens.
Prompt: please fix the four findings [of the 17 bot findings on the PR, the four
judged real: the two workflow permission blocks in the previous commit, and
these two empty excepts]
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent ba4a66f commit bd4780a
1 file changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1434 | 1434 | | |
1435 | 1435 | | |
1436 | 1436 | | |
1437 | | - | |
1438 | | - | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
1439 | 1440 | | |
1440 | 1441 | | |
1441 | 1442 | | |
| |||
1448 | 1449 | | |
1449 | 1450 | | |
1450 | 1451 | | |
1451 | | - | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
1452 | 1459 | | |
1453 | 1460 | | |
1454 | 1461 | | |
| |||
1474 | 1481 | | |
1475 | 1482 | | |
1476 | 1483 | | |
1477 | | - | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
1478 | 1487 | | |
1479 | 1488 | | |
1480 | 1489 | | |
| |||
0 commit comments