Don't display frame ID on stack trace#933
Open
samisalreadytaken wants to merge 1 commit intopuremourning:masterfrom
Open
Don't display frame ID on stack trace#933samisalreadytaken wants to merge 1 commit intopuremourning:masterfrom
samisalreadytaken wants to merge 1 commit intopuremourning:masterfrom
Conversation
Owner
9517ce5 to
c252f5f
Compare
puremourning
requested changes
Aug 9, 2025
Owner
puremourning
left a comment
There was a problem hiding this comment.
Good idea.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @samisalreadytaken)
python3/vimspector/stack_trace.py line 684 at r1 (raw file):
self._buf, ' {0}@{1}:{2}'.format( frame[ 'name' ], source[ 'name' ],
Fix formatting.
Owner
|
Thanks! Just a nit and we can merge |
c252f5f to
91ad657
Compare
Contributor
Author
|
Should the lines be indented for clarity? |
Owner
Hmm. Yeah maybe. The old id served as a visual marker but now we have a little ambiguity. Try it. See what you think. |
91ad657 to
20602bd
Compare
Contributor
Author
|
I think it's better with it, also more consistent with the "tree" style expand. |
Owner
|
Agreed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frame ID is an opaque data that does not concern the end user. Different servers assign them differently. For example this python server has IDs 3,2,12,24; this c server has [1000,1007]; and my debugger simply increments an index with no order.
Don't print this internal info to save screen space and prevent potential confusion.