Stake review shows 0% client share for high-fee providers — needs clarification

[jorgecuesta]

Problem

User reported "rev share should be 50% but UI says 0%" when reviewing stake against provider Kleomedes (Discord, 2026-05-27).

Root cause (not a bug, config)

Provider Kleomedes is configured with:

• revShare: 99% to provider's own address
• supplierShare: 1%, addSupplierShare: true

shareCalculations.ts:79-82 computes:
clientShare = max(0, 100 - 99 - 1 - delegatorFee) = 0%

The math is correct. The user's expectation (50%) doesn't match the provider's actual configuration.

Discussion

• Is 0% client share a valid configuration we should allow without warning the user?
• The Stake Review UI should make it explicit where the rev share is going (provider address vs. supplier address vs. client)
• Consider showing a warning when clientShare = 0 ("You will receive 0% of rewards from this provider")

Files

• apps/middleman/src/lib/utils/shareCalculations.ts
• apps/middleman/src/app/app/stake/components/ReviewStep/