Ability to specify schemas that exist only for PoE 1

[adamthedash]

At the moment we can:

• Add a table at dat-schema/*.gql -> Common schema
• Add a table at dat-schema/*.gql and at dat-schema/poe2/*.gql -> PoE1 and PoE2 schemas
• Add a table at dat-schema/poe2/*.gql -> PoE2 only schema

However I don't believe we have a way to specify tables which exist only in PoE 1.
As of 4.4.0.10, there are 173 tables which have common schemas but don't exist in PoE1 (Most but not all are poe1 league-related). This'll only increase as the two games diverge.

Re-organising to something like:
common/*.gql
poe1/*.gql
poe2/*.gql

might make more sense rather than the common + poe2 override which we've got now.
It's also a little clearer for newcomers to the repo.

[SnosMe]

Yes, split can be done, but definitely no point/resources for maintaining shared part.

[SnosMe]

clearer for newcomers to the repo

This is valid argument.

On other hand original request to implement this was bad, because ggg is free to remove table at any time and it still will be listed in gql.

[adamthedash]

no point/resources for maintaining shared part

I'm not sure I understand this. It would be similar ongoing maintenance burden to now no? Schema would either exist in common (shared), poe1 + poe2 (both games but different schema), or poe1 / poe2 (only one game). So max 2 places, which is same as now.

ggg is free to remove table at any time and it still will be listed in gql

I would consider this issue the same as if a new column was added to a table - schema is behind reality and someone should contribute updates.

[SnosMe]

It would be similar ongoing maintenance burden

No, because there's is no maintenance right now at all. Imagine a table being introduced in one game first, and later in another. If you find out that schema is identical, you will move definition into shared part, this is not happening right now. Who is going to do this, and do benefits outweight cost? I for example not interested in poe2 at all, and don't want to spend time figuring out similarities.

I would consider this issue.

Well, yes. But if they rely on that property of schema be ready to contribute fixes for removed columns. Same way I contribute schema fixes for tables used in awakened poe trade, but not other tables.

And not rely on someone to delete them.

someone should contribute updates.

[adamthedash]

These issues are still present even now though. Adding a new table to _Core.gql is the same as adding to common.
If you want to do this as a first step that's fine, and if someone else sees that schema is different between games they can contribute the fix. Or if it turns out it's the same in both games then it's win-win.

It's up to the downstream user whether they want to treat the schema as up-to-date. It's not a requirement (or feasible) to keep schema in lockstep, so it's almost always going to be lagging behind.

I'm not asking you to make sure schemas are updated, that's up to the community as a whole :)
The main thing is some way to specify poe1-only schemas, which I don't think is possible now. I'd be happy to contribute the data changes as I have some tools to validate against the game files.

[SnosMe]

I've added a flag to test that split schema will work.

use npm run generate -- --no-schema-sharing

[adamthedash]

How about this instead? adamthedash@fa5dbd6

It would allow overrides for poe1 in poe1/*.gql similar to current poe2 overrides.

Definition in / + /poe1/ -> poe2 + poe1 generated
Definition in / + /poe2/ -> poe1 + poe2 generated
Definition in / -> common generated
Definition in / + /poe1/ + /poe2/ -> poe1 + poe2 generated
Definition in /poe1/ + /poe2/ -> poe1+ poe2 generated
Definition in /poe1/ -> poe1 generated
Definition in /poe2/ -> poe2 generated

[SnosMe]

The problem is there is no such thing as shared schema. GGG's internal tooling doesn't have a "common schema/different data per game" model (not 100% sure tho). Whole data was forked at some point and then changed as needed, this is why you see junk tables not used by game at all. The current schema export is exactly that - base+fork, and if we changing it I only agree on splitting aproach.

Like what would you even put in shared schema, it should be something shared related to Game Engine right? backenderors, gamepadbutton, bindablevirtualkeys tables. But even things that shared as MTX between games I see already have different schemas. League related, endgame tables definitely don't belong in shared.

[adamthedash]

Whole data was forked at some point

Yes it was forked at some point in the past, but changes have happened to both games since, which means really you have base + 2x forks. I'm happy with either base + override or complete split approach, but having base + 2x override would make it possible to incrementally transition to a fully split schema.