Repository navigation
Commit ef9f6ab
committed
feat: auto-pass --no-runtime when the runtime input is set
When the user pins a runtime via the action's `runtime` input, that
runtime has already been installed and put on PATH by the time `pnpm
install` runs. If the project's package.json also declares a different
`devEngines.runtime` with `onFail: download`, pnpm install would fetch
that second runtime and silently swap the active one — defeating the
matrix/explicit pin.
`--no-runtime` (pnpm v11.1.0+) tells pnpm install to skip the runtime
fetch entirely. Appending it whenever the `runtime` input is set
matches user intent: "I told the action which runtime I want, don't
let install second-guess it."
When the input is omitted (runtime fully driven by devEngines.runtime),
`pnpm install` runs unmodified — the devEngines runtime is the only
source of truth and install should honor it.
Adds a `runtime-overrides-devengines` test that pins node@22 in the
action input, declares ^20.0.0 in devEngines.runtime, and asserts node
22 is still active after install.
Bumps test workflow's pnpm pin to 11.1.0 since `--no-runtime` requires it.1 parent 7b64e33 commit ef9f6ab
4 files changed
Lines changed: 68 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
200 | 247 | | |
201 | 248 | | |
202 | 249 | | |
| |||
210 | 257 | | |
211 | 258 | | |
212 | 259 | | |
213 | | - | |
| 260 | + | |
214 | 261 | | |
215 | 262 | | |
216 | 263 | | |
| |||
246 | 293 | | |
247 | 294 | | |
248 | 295 | | |
249 | | - | |
| 296 | + | |
250 | 297 | | |
251 | 298 | | |
252 | 299 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
25 | 33 | | |
26 | 34 | | |
27 | 35 | | |
| |||
0 commit comments