Skip to content

empty-catch: sdks/typescript/pmxt/client.ts:433 — server restart failure silently ignored during retry loop #944

@realfishsam

Description

@realfishsam

Violation

try {
    await this.serverManager.ensureServerRunning();
} catch {
    // Restart failed — continue retrying anyway
}

Location

sdks/typescript/pmxt/client.ts:433

Why It Matters

If ensureServerRunning() throws during a retry loop, the error is silently discarded. There is no log, so there is no way to know whether the server failed to start, threw a permission error, crashed with an uncaught exception, or ran out of resources. A developer debugging a "client never connects" issue has no trail to follow.

Suggested Fix

} catch (err) {
    logger.warn('PmxtClient: server restart failed during retry', { attempt, error: String(err) });
}

Found by automated code hygiene audit

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions