Repository navigation
Commit 4ac87c9
authored
fix(cli): remove Windows-breaking postinstall chmod (#669)
## Summary
- The `pgflow` package's `postinstall` ran `chmod +x dist/index.js || true`. `chmod` and `true` do not exist in Windows cmd.exe, so `npm install pgflow` and `npx pgflow@latest install` failed with `'chmod' is not recognized as an internal or external command`.
- npm sets the executable bit on files declared in the `bin` field during install, so the script was redundant even on Unix. Removal is the whole fix.
- Adds a permanent `windows-latest` smoke workflow as the regression test: build the CLI, `pnpm pack`, install the tarball into a clean directory with lifecycle scripts enabled, run the npm-created `pgflow.cmd --version` shim. The rest of CI runs on Ubuntu and invokes `node dist/index.js` directly, so npm installation and Windows shims were never exercised.
- One `pgflow` patch changeset for the 0.15.1 release group (#666).
- Recreates the minimal removal from #612 against current `main` (#612 was based on v0.13.3).
## Checks
- `pnpm nx build cli` — pass
- `pnpm pack` in `pkgs/cli` — tarball contains `dist/`, no `postinstall` in its `package.json`
- CLI unit tests — 43/43 pass
- `prettier --check` on all three touched files — pass
- Windows smoke job runs in this PR's CI
Closes #6101 parent 078aa1e commit 4ac87c9
3 files changed
Lines changed: 61 additions & 4 deletions
File tree
- .changeset
- .github/workflows
- pkgs/cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 40 | + | |
44 | 41 | | |
0 commit comments