Add tests for cinderBackups in dz-storage scenario#3927
Conversation
|
Hi @gais-ameer-rh. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 53s |
To deploy multiple cinder backups based on AZ topology Removes the existing spec.cinder.template.cinderBackup (singluar) and replaces with cinderBackups (plural) Depends-On: openstack-k8s-operators/ci-framework#3927 OSPRH-28342
gais-ameer-rh
force-pushed
the
cinderBackups
branch
from
1c8d775 to
bb02fb1
Compare
|
recheck |
fultonj
left a comment
fultonj
left a comment
There was a problem hiding this comment.
Thanks Gais! A few suggestions.
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 51s |
gais-ameer-rh
force-pushed
the
cinderBackups
branch
from
acb468f to
37d554e
Compare
|
Overall this /lgtm Let's confirm we get a green test project before merging. |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 32m 46s |
|
The backups playbook passed in a test project |
I believe this is the pre-commit failure: |
|
Since this playbook will also be used with DCN per this change: Do you want to rename the playbook file to remove "dz" from it? Also, can you add support for overriding the AZ names by making them variables. I think the DCN job has the same AZ names, but it's going to be useful to have them not hard coded. |
gais-ameer-rh
force-pushed
the
cinderBackups
branch
from
78d6b12 to
8076af8
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 14s |
|
recheck |
|
/lgtm |
spec.cinder.template.cinderBackup (singluar) in DZ-Storage DT is replaced with cinderBackups (plural) to deploy multiple cinder backups based on AZ topology. hooks/playbooks/cinder_backups.yaml validates the behaviour of cinderBackups. The playbook tests different scenarios of cinder backup creation and restoring the backups across availability zones. Jira: OSPRH-28342 Signed-off-by: Gais Ameer <gameer@redhat.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
gais-ameer-rh
force-pushed
the
cinderBackups
branch
from
8076af8 to
74e6974
Compare
|
/lgtm |
|
@evallesp I think this is safe to merge since it's adding a new playbook and not changing any existing files. If you're happy with the changes that @gais-ameer-rh made are you OK with merging? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evallesp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit db06864
into
openstack-k8s-operators:main
[DZ-Storage] Adding cinderBackups to controlplane To deploy multiple cinder backups based on AZ topology Removes the existing spec.cinder.template.cinderBackup (singluar) and replaces with cinderBackups (plural) Jira: OSPRH-28342 Signed-off-by: Gais Ameer gameer@redhat.com Depends-On: openstack-k8s-operators/ci-framework#3927 Reviewed-by: John Fulton <johfulto@redhat.com> Reviewed-by: Gais Ameer Reviewed-by: Andrew Bays <andrew.bays@gmail.com>
4 participants
[DZ-Storage] Add tests for cinderBackups
spec.cinder.template.cinderBackup (singluar) in DZ-Storage DT is
replaced with cinderBackups (plural) to deploy multiple cinder backups based on AZ topology.
hooks/playbooks/cinder_backups.yaml validates the behaviour of cinderBackups.
The playbook tests different scenarios of cinder backup creation
and restoring the backups across availability zones.
Jira: OSPRH-28342
Signed-off-by: Gais Ameer gameer@redhat.com
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com