Review Notes for PR #22
(a) New provider files lack unit tests
The new provider parsing/normalization files have no test coverage.
(b) mergeEntries cost distribution bug
When mixing providers with and without cost breakdowns (e.g., Claude with modelBreakdown + a provider that only has total cost), the merge logic may misattribute costs.
(c) Model prettification missing from post-share.ts and recap.ts
The prettifyModel function in ActivityCard.tsx now handles new provider models (GPT, o3, o4), but post-share.ts and recap.ts have their own copies that don't know about non-Claude models. Shared post images and recap cards will show raw model IDs.
(d) ModelBreakdownEntry should include provider field
The ModelBreakdownEntry type currently only has model and cost_usd. Adding a provider field would future-proof for model name disambiguation.
Review Notes for PR #22
(a) New provider files lack unit tests
The new provider parsing/normalization files have no test coverage.
(b) mergeEntries cost distribution bug
When mixing providers with and without cost breakdowns (e.g., Claude with
modelBreakdown+ a provider that only has total cost), the merge logic may misattribute costs.(c) Model prettification missing from post-share.ts and recap.ts
The
prettifyModelfunction inActivityCard.tsxnow handles new provider models (GPT, o3, o4), butpost-share.tsandrecap.tshave their own copies that don't know about non-Claude models. Shared post images and recap cards will show raw model IDs.(d) ModelBreakdownEntry should include provider field
The
ModelBreakdownEntrytype currently only hasmodelandcost_usd. Adding aproviderfield would future-proof for model name disambiguation.