Skip to content

Commit e584b81

Browse files
chore: size scenario changesets as patch, not minor (#143)
The changeset that came in with #133 was a `minor`, so the pending release PR proposed `0.5.0`. That number is reserved for OCPP 2.0.1 in both `ROADMAP.md` and `CURRENT_STATE.md`. Spending it on one new scenario would push the 2.0.1 work to `0.6.0` and break the milestone-to-version mapping the project has held since v0.1. Retags the pending changeset to `patch`, so the release recomputes to `0.4.3`. Nothing had published yet, so the change was free to make. Adds the convention to the "Adding a Scenario" section, which did not mention changesets at all. That omission is how the wrong size arrived: #133 was asked for a minor during review, and #137, #138 and #139 are queued behind it. A new scenario does add a public export, but scenarios are test corpus rather than consumer API surface: nothing is built against an individual scenario constant, and the registry is consumed as a whole through `scenarios` and `getScenario()`. Minor and major stay reserved for changes to the analysis engine. Closes #142
1 parent 9e1a294 commit e584b81

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

‎.changeset/warm-dragons-smile.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
"@ocpp-debugkit/toolkit": minor
2+
"@ocpp-debugkit/toolkit": patch
33
---
44

55
feat(scenarios): add firmware update success scenario

‎CONTRIBUTING.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,14 @@ trace with expected failure outcomes and optional assertions.
238238
check from [Verify Locally](#4-verify-locally). `ocpp-debugkit ci` does not
239239
cover formatting, lint, or types.
240240

241+
5. Add a changeset with `pnpm changeset`, and pick **patch**. A new scenario does
242+
add a public export, but scenarios are test corpus rather than consumer API
243+
surface: nothing is built against an individual scenario constant, and the
244+
registry is consumed as a whole through `scenarios` and `getScenario()`.
245+
Minor and major releases are reserved for changes to the analysis engine, so
246+
version numbers keep lining up with the milestones in
247+
[ROADMAP.md](ROADMAP.md).
248+
241249
### Guidelines
242250

243251
- All data must be **synthetic** — no real station IDs, transaction IDs, idTags,

0 commit comments

Comments
 (0)