Repository navigation
Commit ab968f0
authored
docs: require a scenario for every detection rule (#148)
Three of the 16 detection rules shipped with no scenario exercising them:
TIMEOUT_NO_HEARTBEAT, FIRMWARE_UPDATE_FAILURE and REPEATED_BOOT_NOTIFICATION.
REPEATED_BOOT_NOTIFICATION is the worked example: it landed in #114 and no
scenario followed, because the checklist never asked for one.
States the invariant at the top of "Contributing Detection Rules" and adds it as
step 7 of the checklist, paired with the step 6 false-positive audit. Step 6
confirms a rule stays quiet where it should; step 7 confirms it fires where it
should. The three uncovered rules are being filled by #137, #138 and #139.
Closes #1401 parent 450b5be commit ab968f0
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
264 | 271 | | |
265 | 272 | | |
266 | 273 | | |
| |||
290 | 297 | | |
291 | 298 | | |
292 | 299 | | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
293 | 305 | | |
294 | 306 | | |
295 | 307 | | |
| |||
0 commit comments