Skip to content

Commit 6f7c081

Browse files
docs: record complete rule coverage and the corpus reaching 21 (#172)
#169 and #170 landed together, so this folds both forward. Rule coverage is complete: all 16 detection rules now have a scenario exercising them, the invariant #140 wrote into CONTRIBUTING. Verified by iterating the registry rather than by reading, 16 of 16 codes appear in some scenario's expectedFailures. The corpus is at 21, clearing the 20+ scenario exit criterion in the v1.0 milestone. Records the fifth and sixth good-first-issue completions (#108 by YANGCHUNHONG3000, #139 by MayurK-cmd), why #170 needed its branch repaired (cut before #161, its conflict resolution deleted heartbeat-timeout.ts and left stray markers that broke typecheck and build), and the station ID allocation now that 020 and 021 have shipped and 022 is next free.
1 parent 49bc07e commit 6f7c081

1 file changed

Lines changed: 27 additions & 12 deletions

File tree

‎CURRENT_STATE.md‎

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -407,11 +407,12 @@ these fixes introduce is required across detection.
407407
only on negative or decreasing cumulative readings, and a flat series is
408408
neither.
409409
- ✅ Station IDs allocated per issue so parallel work cannot collide:
410-
`CS-SYNTHETIC-016` shipped in #133, `018` shipped in #161, `019` shipped in
411-
#147, `020` reserved for #139, `021` reserved for #108. `017` is NOT free:
412-
`refused-authorization.ts` took it in `0.4.5`, which is why #108 moved off it.
413-
Live allocation is 004 through 019 in use, 020 and 021 reserved, so the next
414-
free number is 022.
410+
`CS-SYNTHETIC-016` shipped in #133, `018` in #161, `019` in #147, `020` in #170,
411+
`021` in #169. `017` is NOT free: `refused-authorization.ts` took it in `0.4.5`,
412+
which is why #108 moved off it. Live allocation is 004 through 021 all in use, so
413+
the next free number is 022.
414+
The `021` move also needed the `idTag` and `transactionId` renumbered to match,
415+
which #108 still carried from before the move; caught in review of #169.
415416
- ✅ #140 landed (PR #148): the standing invariant that every detection rule
416417
ships with a scenario in the same PR, added to `CONTRIBUTING.md` as a statement
417418
and as step 7 of the rule checklist. This is what stops the coverage gap
@@ -448,13 +449,27 @@ these fixes introduce is required across detection.
448449
hand. Nine scenario files assert things nothing verifies. Found while reviewing
449450
#161; pre-existing and unrelated to that contribution.
450451

451-
Rule coverage: after #161, one of the sixteen detection rules still lacks a
452-
scenario. Verified by iterating the registry, 15 of the 16 codes appear in some
453-
scenario's `expectedFailures`, and `REPEATED_BOOT_NOTIFICATION` (#139, assigned)
454-
is the sole gap.
455-
456-
Scenario arithmetic to the v1.0 target of 20+: 19 today, and #108 plus #139 take
457-
it to 21, at which point all 16 detection rules are covered.
452+
- ✅ Fifth and sixth `good-first-issue` completions landed together: #108
453+
(`meter-value-zero`) by `YANGCHUNHONG3000`, their third, and #139
454+
(`repeated-boot-notification`) by `MayurK-cmd`, their second (PRs #169 and #170).
455+
Both arrived within two days of being assigned.
456+
- ✅ #170 needed its branch repaired before it could land, and the repair is worth
457+
recording because the failure mode is easy to repeat. It was cut before #161 and
458+
the conflict resolution deleted `heartbeat-timeout.ts`, which would have reverted
459+
#161, and left three stray `>` characters in `index.ts` and `index.test.ts` that
460+
broke `typecheck` and `build`. The scenario file and changeset were fine; only the
461+
merge was wrong.
462+
- ✅ Both PRs also confirmed the review habit that keeps paying: neither touched the
463+
detection-rule count, the trap an earlier contribution fell into.
464+
465+
Rule coverage: **complete**. All 16 detection rules now have a scenario exercising
466+
them, the invariant #140 put in `CONTRIBUTING.md`. Verified by iterating the
467+
registry rather than by reading: 16 of 16 codes appear in some scenario's
468+
`expectedFailures`.
469+
470+
Scenario corpus: **21**, which clears the 20+ target in the v1.0 milestone
471+
(`ROADMAP.md` line 157). That exit criterion is met; the remaining v1.0 work is API
472+
stabilization, the docs overhaul and release hardening.
458473

459474
### Release Log Automation (Issue #151, PR #152)
460475

0 commit comments

Comments
 (0)