Skip to content

feat: add unused configs#60

Merged
nomutin merged 12 commits into
masterfrom
clean
Apr 17, 2026
Merged

feat: add unused configs#60
nomutin merged 12 commits into
masterfrom
clean

Conversation

@nomutin
Copy link
Copy Markdown
Owner

@nomutin nomutin commented Apr 17, 2026

No description provided.

@nomutin nomutin changed the title feat: add pi coding agent feat: add unused configs Apr 17, 2026
@nomutin nomutin requested a review from Copilot April 17, 2026 15:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the dotfiles’ XDG-based configuration set (vim/tmux/mise/ghostty/cutler) and updates the installation/linting setup to match the new config layout.

Changes:

  • Adds/updates XDG configs for mise (env/hooks + development overlay), tmux (extended keys), vim (LSP/Copilot settings), and ghostty (new config).
  • Extends macOS automation via cutler config (Finder/Dock defaults + Homebrew bundle section).
  • Simplifies the installer and repo docs by removing bash dotfiles and adjusting CI ShellCheck patterns.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
xdg_config/vim/vimrc Tweaks vim plugin setup (vim-lsp placement, python LSP settings) and adds Copilot plugin.
xdg_config/tmux/tmux.conf Enables tmux extended key reporting for improved key handling.
xdg_config/mise/miserc.toml Adds a (currently commented) mise env selector placeholder.
xdg_config/mise/config.toml Moves shell environment/aliases/hooks into mise and updates tool list/settings.
xdg_config/mise/config.development.toml Introduces a development overlay with additional tools and env vars.
xdg_config/ghostty/config.ghostty Adds Ghostty terminal configuration.
xdg_config/cutler/config.toml Updates Finder defaults and adds Dock + brew automation blocks.
install.sh Removes dot-config deployment and adds mise setup + macOS prerequisites changes.
dot_config/profile Removes legacy login-shell profile config.
dot_config/bashrc Removes legacy interactive bash configuration.
README.md Updates documented “Settings for” list and removes bash-specific install instructions.
.github/workflows/lint-configs.yaml Adjusts ShellCheck include patterns to only *.sh.
Comments suppressed due to low confidence (1)

install.sh:55

  • The installer hard-codes ~/.local/bin/mise for activation but uses mise install ... for installs. This can break in two cases: (1) if mise was already installed somewhere else (Homebrew/system), the appended activation line points to a non-existent path; (2) after installing via curl | sh, mise may still not be on PATH, so mise install can fail. Prefer using mise_cmd='eval "$(mise activate bash)"' (or derive the path from command -v mise) and invoke mise consistently via that resolved path.
  if ! command -v mise >/dev/null 2>&1; then
    log_info "Installing mise..."
    curl https://mise.run | sh
  fi
  mise_cmd="eval \"\$(~/.local/bin/mise activate bash)\""
  if ! grep -Fxq "${mise_cmd}" "${HOME}/.bash_profile"; then
    log_info "Adding mise activation to .bash_profile"
    echo "${mise_cmd}" >>"${HOME}/.bash_profile"
  fi
  log_info "Installing dependencies with mise..."
  mise install -yq
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread install.sh
Comment thread xdg_config/cutler/config.toml Outdated
Comment thread README.md
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread xdg_config/nvim/init.lua
Comment thread xdg_config/zellij/config.kdl
@nomutin nomutin merged commit 1a23b4a into master Apr 17, 2026
5 of 6 checks passed
@nomutin nomutin deleted the clean branch April 17, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants