Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the dotfiles’ XDG-based configuration set (vim/tmux/mise/ghostty/cutler) and updates the installation/linting setup to match the new config layout.
Changes:
- Adds/updates XDG configs for mise (env/hooks + development overlay), tmux (extended keys), vim (LSP/Copilot settings), and ghostty (new config).
- Extends macOS automation via cutler config (Finder/Dock defaults + Homebrew bundle section).
- Simplifies the installer and repo docs by removing bash dotfiles and adjusting CI ShellCheck patterns.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
xdg_config/vim/vimrc |
Tweaks vim plugin setup (vim-lsp placement, python LSP settings) and adds Copilot plugin. |
xdg_config/tmux/tmux.conf |
Enables tmux extended key reporting for improved key handling. |
xdg_config/mise/miserc.toml |
Adds a (currently commented) mise env selector placeholder. |
xdg_config/mise/config.toml |
Moves shell environment/aliases/hooks into mise and updates tool list/settings. |
xdg_config/mise/config.development.toml |
Introduces a development overlay with additional tools and env vars. |
xdg_config/ghostty/config.ghostty |
Adds Ghostty terminal configuration. |
xdg_config/cutler/config.toml |
Updates Finder defaults and adds Dock + brew automation blocks. |
install.sh |
Removes dot-config deployment and adds mise setup + macOS prerequisites changes. |
dot_config/profile |
Removes legacy login-shell profile config. |
dot_config/bashrc |
Removes legacy interactive bash configuration. |
README.md |
Updates documented “Settings for” list and removes bash-specific install instructions. |
.github/workflows/lint-configs.yaml |
Adjusts ShellCheck include patterns to only *.sh. |
Comments suppressed due to low confidence (1)
install.sh:55
- The installer hard-codes
~/.local/bin/misefor activation but usesmise install ...for installs. This can break in two cases: (1) if mise was already installed somewhere else (Homebrew/system), the appended activation line points to a non-existent path; (2) after installing viacurl | sh,misemay still not be onPATH, somise installcan fail. Prefer usingmise_cmd='eval "$(mise activate bash)"'(or derive the path fromcommand -v mise) and invoke mise consistently via that resolved path.
if ! command -v mise >/dev/null 2>&1; then
log_info "Installing mise..."
curl https://mise.run | sh
fi
mise_cmd="eval \"\$(~/.local/bin/mise activate bash)\""
if ! grep -Fxq "${mise_cmd}" "${HOME}/.bash_profile"; then
log_info "Adding mise activation to .bash_profile"
echo "${mise_cmd}" >>"${HOME}/.bash_profile"
fi
log_info "Installing dependencies with mise..."
mise install -yq
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.