test: Add comprehensive tests for project components and error handling

Author: kaburagisec

tests/__init__.py

@@ -0,0 +1,127 @@
+# tests/conftest.py
+
+import pytest
+from unittest.mock import Mock, MagicMock, patch
+from onvif import ONVIFClient, CacheMode
+
+
+@pytest.fixture
+def mock_device_response():
+    """Mock device information response"""
+    mock_device = Mock()
+    mock_device.Manufacturer = "Test Manufacturer"
+    mock_device.Model = "Test Model"
+    mock_device.FirmwareVersion = "1.0.0"
+    mock_device.SerialNumber = "TEST123456"
+    mock_device.HardwareId = "TEST_HW_001"
+    return mock_device
+
+
+@pytest.fixture
+def mock_capabilities():
+    """Mock capabilities response"""
+    mock_caps = Mock()
+    
+    # Media capabilities
+    mock_caps.Media = Mock()
+    mock_caps.Media.XAddr = "http://192.168.1.17:8000/onvif/Media"
+    
+    # PTZ capabilities
+    mock_caps.PTZ = Mock()
+    mock_caps.PTZ.XAddr = "http://192.168.1.17:8000/onvif/PTZ"
+    
+    # Extension capabilities
+    mock_caps.Extension = Mock()
+    mock_caps.Extension.DeviceIO = Mock()
+    mock_caps.Extension.DeviceIO.XAddr = "http://192.168.1.17:8000/onvif/DeviceIO"
+    
+    return mock_caps
+
+
+@pytest.fixture
+def mock_services():
+    """Mock GetServices response"""
+    service1 = Mock()
+    service1.Namespace = "http://www.onvif.org/ver10/media/wsdl"
+    service1.XAddr = "http://192.168.1.17:8000/onvif/Media"
+    
+    service2 = Mock()
+    service2.Namespace = "http://www.onvif.org/ver20/ptz/wsdl"
+    service2.XAddr = "http://192.168.1.17:8000/onvif/PTZ"
+    
+    return [service1, service2]
+
+
+@pytest.fixture
+def mock_onvif_client():
+    """Create a mocked ONVIF client for testing"""
+    with patch('onvif.client.Device') as mock_device_class:
+        # Mock the Device class to avoid real network calls
+        mock_device = Mock()
+        mock_device_class.return_value = mock_device
+        
+        client = ONVIFClient(
+            host="192.168.1.17",
+            port=8000,
+            username="admin", 
+            password="admin123",
+            timeout=5,
+            cache=CacheMode.NONE  # Disable caching for tests
+        )
+        
+        # Set up mock responses
+        mock_device.GetDeviceInformation.return_value = Mock(
+            Manufacturer="Test Manufacturer",
+            Model="Test Model", 
+            FirmwareVersion="1.0.0",
+            SerialNumber="TEST123456",
+            HardwareId="TEST_HW_001"
+        )
+        
+        # Create mock capabilities
+        mock_caps = Mock()
+        mock_caps.Media = Mock()
+        mock_caps.Media.XAddr = "http://192.168.1.17:8000/onvif/Media"
+        mock_caps.PTZ = Mock()
+        mock_caps.PTZ.XAddr = "http://192.168.1.17:8000/onvif/PTZ"
+        mock_caps.Extension = Mock()
+        mock_caps.Extension.DeviceIO = Mock()
+        mock_caps.Extension.DeviceIO.XAddr = "http://192.168.1.17:8000/onvif/DeviceIO"
+        mock_device.GetCapabilities.return_value = mock_caps
+        
+        # Create mock services
+        service1 = Mock()
+        service1.Namespace = "http://www.onvif.org/ver10/media/wsdl"
+        service1.XAddr = "http://192.168.1.17:8000/onvif/Media"
+        service2 = Mock()
+        service2.Namespace = "http://www.onvif.org/ver20/ptz/wsdl"
+        service2.XAddr = "http://192.168.1.17:8000/onvif/PTZ"
+        mock_device.GetServices.return_value = [service1, service2]
+        
+        client._devicemgmt = mock_device
+        yield client
+
+
+@pytest.fixture
+def sample_subscription_ref():
+    """Sample subscription reference for pullpoint tests"""
+    return {
+        "SubscriptionReference": {
+            "Address": {
+                "_value_1": "http://192.168.1.17:8000/onvif/Subscription/12345"
+            }
+        }
+    }
+
+
+@pytest.fixture
+def test_client_params():
+    """Standard test client parameters"""
+    return {
+        "host": "192.168.1.17",
+        "port": 8000,
+        "username": "admin",
+        "password": "admin123",
+        "timeout": 5,
+        "cache": CacheMode.NONE
+    }

tests/conftest.py

@@ -0,0 +1,6 @@
+import pytest
+from onvif.services.accesscontrol import AccessControl
+
+
+def test_accesscontrol_import():
+    assert AccessControl is not None

tests/services/test_accesscontrol.py

@@ -0,0 +1,6 @@
+import pytest
+from onvif.services.accessrules import AccessRules
+
+
+def test_accessrules_import():
+    assert AccessRules is not None

tests/services/test_accessrules.py

@@ -0,0 +1,6 @@
+import pytest
+from onvif.services.actionengine import ActionEngine
+
+
+def test_actionengine_import():
+    assert ActionEngine is not None

tests/services/test_actionengine.py

@@ -1,6 +1,6 @@
 import pytest
-from onvif.services.security import advancedsecurity
+from onvif.services.security.advancedsecurity import AdvancedSecurity
 
 
 def test_advancedsecurity_import():
-    assert advancedsecurity is not None
+    assert AdvancedSecurity is not None

tests/services/test_advancedsecurity.py

@@ -1,6 +1,6 @@
 import pytest
-from onvif.services.analytics import analytics
+from onvif.services.analytics.analytics import Analytics
 
 
 def test_analytics_import():
-    assert analytics is not None
+    assert Analytics is not None

tests/services/test_analytics.py

@@ -0,0 +1,6 @@
+import pytest
+from onvif.services.analyticsdevice import AnalyticsDevice
+
+
+def test_analyticsdevice_import():
+    assert AnalyticsDevice is not None

tests/services/test_analyticsdevice.py

@@ -1,6 +1,6 @@
 import pytest
-from onvif.services import appmgmt
+from onvif.services.appmgmt import AppManagement
 
 
 def test_appmgmt_import():
-    assert appmgmt is not None
+    assert AppManagement is not None

tests/services/test_appmgmt.py

@@ -1,6 +1,6 @@
 import pytest
-from onvif.services import authenticationbehavior
+from onvif.services.authenticationbehavior import AuthenticationBehavior
 
 
 def test_authenticationbehavior_import():
-    assert authenticationbehavior is not None
+    assert AuthenticationBehavior is not None