Skip to content

signaling: Improve error handling when joining a room #12750

@fancycode

Description

@fancycode

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

If joining a room fails, the error is currently not handled:

console.debug('Joined', data, token)

The join request is not retried or the error otherwise handled, so the signaling server will close the session if it's an anonymous user and disconnect the websocket:
https://github.com/strukturag/nextcloud-spreed-signaling/blob/98bf947ce36657b58b815c997805fe9cb7bf8471/hub.go#L664

This will trigger a reconnect in the client which tries to resume the (already deleted) session.

@danxuliu I noticed this while testing #12604 where errors while joining can happen much more often than normally.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions