From a93d904a46d53e89e7cae96bbfa863f1bf35d6c3 Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 27 May 2026 17:06:45 -0400 Subject: [PATCH 1/3] fix(Storage): use proxyexclude parameter in DAV client Signed-off-by: Josh --- lib/private/Files/Storage/DAV.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/private/Files/Storage/DAV.php b/lib/private/Files/Storage/DAV.php index df87b1b98f5e0..25d4bd1c43b3c 100644 --- a/lib/private/Files/Storage/DAV.php +++ b/lib/private/Files/Storage/DAV.php @@ -157,6 +157,11 @@ protected function init(): void { $this->client = new Client($settings); $this->client->setThrowExceptions(true); + $proxyExclude = Server::get(IConfig::class)->getSystemValue('proxyexclude', []); + if (!empty($proxyExclude)) { + $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); + } + if ($this->secure === true) { if ($this->verify === false) { $this->client->addCurlSetting(CURLOPT_SSL_VERIFYPEER, false); From 21b476ae6ce053c51973043aa6632ab74b94c886 Mon Sep 17 00:00:00 2001 From: Josh Date: Wed, 27 May 2026 17:25:58 -0400 Subject: [PATCH 2/3] chore(DAV): fixup for lint Signed-off-by: Josh --- lib/private/Files/Storage/DAV.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/DAV.php b/lib/private/Files/Storage/DAV.php index 25d4bd1c43b3c..f119dd5aec896 100644 --- a/lib/private/Files/Storage/DAV.php +++ b/lib/private/Files/Storage/DAV.php @@ -159,7 +159,7 @@ protected function init(): void { $proxyExclude = Server::get(IConfig::class)->getSystemValue('proxyexclude', []); if (!empty($proxyExclude)) { - $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); + $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); } if ($this->secure === true) { From 27131f9094ea59b7ce09c08c8cf017c1e8622035 Mon Sep 17 00:00:00 2001 From: Josh Date: Thu, 28 May 2026 13:10:56 -0400 Subject: [PATCH 3/3] chore(DAV): fixup proxyexclude default value check Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Josh --- lib/private/Files/Storage/DAV.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/DAV.php b/lib/private/Files/Storage/DAV.php index f119dd5aec896..ecae2b4a3f569 100644 --- a/lib/private/Files/Storage/DAV.php +++ b/lib/private/Files/Storage/DAV.php @@ -158,7 +158,7 @@ protected function init(): void { $this->client->setThrowExceptions(true); $proxyExclude = Server::get(IConfig::class)->getSystemValue('proxyexclude', []); - if (!empty($proxyExclude)) { + if ($proxyExclude !== []) { $this->client->addCurlSetting(CURLOPT_NOPROXY, implode(',', $proxyExclude)); }