chore: Use a better naming for init function

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Author: come-nc

index.php

@@ -25,8 +25,7 @@
 
 \OC::handleRequests(static function () {
 	try {
-		\OC::resetStaticProperties();
-		\OC::init();
+		\OC::initForRequest();
 		\OC::handleRequest();
 	} catch (ServiceUnavailableException $ex) {
 		Server::get(LoggerInterface::class)->error($ex->getMessage(), [

lib/OC.php

@@ -666,6 +666,9 @@ private static function addSecurityHeaders(): void {
 		}
 	}
 
+	/*
+	 * Called only once at the beginning to setup things
+	 */
 	public static function boot(): void {
 		// prevent any XML processing from loading external entities
 		libxml_set_external_entity_loader(static function () {
@@ -726,7 +729,12 @@ public static function boot(): void {
 		}
 	}
 
-	public static function init(): void {
+	/*
+	 * Called before each request served if the same worker serves several request
+	 */
+	public static function initForRequest(): void {
+		self::resetStaticProperties();
+
 		// First handle PHP configuration and copy auth headers to the expected
 		// $_SERVER variable before doing anything Server object related
 		self::setRequiredIniValues();
@@ -1329,7 +1337,7 @@ protected static function tryAppAPILogin(OCP\IRequest $request): bool {
 	/**
 	 * @internal
 	 */
-	public static function resetStaticProperties(): void {
+	private static function resetStaticProperties(): void {
 		// FIXME needed because these use a static var
 		\OC_Hook::clear();
 		\OC_Util::$styles = [];

lib/base.php

@@ -9,4 +9,4 @@
 require_once __DIR__ . '/OC.php';
 
 \OC::boot();
-\OC::init();
+\OC::initForRequest();

ocs/v1.php

@@ -31,8 +31,7 @@
 \OC::boot();
 
 \OC::handleRequests(static function () {
-	\OC::resetStaticProperties();
-	\OC::init();
+	\OC::initForRequest();
 	$request = Server::get(IRequest::class);
 
 	if ((Util::needUpgrade() || Server::get(IConfig::class)->getSystemValueBool('maintenance')) && $request->getPathInfo() !== '/core/update') {

remote.php

@@ -103,8 +103,7 @@ function resolveService($service) {
 
 \OC::handleRequests(static function () {
 	try {
-		\OC::resetStaticProperties();
-		\OC::init();
+		\OC::initForRequest();
 
 		// All resources served via the DAV endpoint should have the strictest possible
 		// policy. Exempted from this is the SabreDAV browser plugin which overwrites