Skip to content

Commit c82a8cc

Browse files
ada-x64ppenna
authored andcommitted
re-enable NSKIP040/NSKIP041 tests (writev/pwritev overflow EINVAL)
Remove the NSKIP040 (#520) and NSKIP041 (#521) skips on test_pwritev_overflow_32bits and test_writev_overflow_32bits. The nanvix libc writev/pwritev now validate sum(iov_len) against SSIZE_MAX before dispatch and return EINVAL on overflow (nanvix#3064), so both tests pass. The pwritev short-circuit also fixes the previous overflow-path hang.
1 parent 8b001dc commit c82a8cc

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

‎Lib/test/test_posix.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -399,9 +399,6 @@ def test_pwritev_flags(self):
399399
finally:
400400
os.close(fd)
401401

402-
# NSKIP040 https://github.com/nanvix/cpython/issues/520
403-
@unittest.skipIf(support.is_nanvix,
404-
"NSKIP040: os.pwritev() with overflow-sized iovecs hangs on Nanvix")
405402
@unittest.skipUnless(hasattr(posix, 'pwritev'), "test needs posix.pwritev()")
406403
@requires_32b
407404
def test_pwritev_overflow_32bits(self):
@@ -524,9 +521,6 @@ def test_writev(self):
524521
finally:
525522
os.close(fd)
526523

527-
# NSKIP041 https://github.com/nanvix/cpython/issues/521
528-
@unittest.skipIf(support.is_nanvix,
529-
"NSKIP041: os.writev() not supported") # detail: ENOSPC instead of EINVAL on overflow
530524
@unittest.skipUnless(hasattr(posix, 'writev'), "test needs posix.writev()")
531525
@requires_32b
532526
def test_writev_overflow_32bits(self):

0 commit comments

Comments
 (0)