Skip to content

Commit c2a68e8

Browse files
ada-x64ppenna
authored andcommitted
Re-enable NSKIP029
fchmod/fchown reject invalid fds now. (test_os stays in STANDALONE_EXCLUDE for unrelated pre-existing failures.)
1 parent b73387d commit c2a68e8

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

‎Lib/test/test_os.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2402,16 +2402,10 @@ def test_dup2_negative_fd(self):
24022402
os.dup2(fd, fd2)
24032403
self.assertEqual(ctx.exception.errno, errno.EBADF)
24042404

2405-
# NSKIP029 https://github.com/nanvix/cpython/issues/509
2406-
@unittest.skipIf(support.is_nanvix,
2407-
"NSKIP029: os.fchmod/fchown accepts invalid fd silently") # detail: os.fchmod
24082405
@unittest.skipUnless(hasattr(os, 'fchmod'), 'test needs os.fchmod()')
24092406
def test_fchmod(self):
24102407
self.check(os.fchmod, 0)
24112408

2412-
# NSKIP029 https://github.com/nanvix/cpython/issues/509
2413-
@unittest.skipIf(support.is_nanvix,
2414-
"NSKIP029: os.fchmod/fchown accepts invalid fd silently") # detail: os.fchown
24152409
@unittest.skipUnless(hasattr(os, 'fchown'), 'test needs os.fchown()')
24162410
def test_fchown(self):
24172411
self.check(os.fchown, -1, -1)

0 commit comments

Comments
 (0)