refactor(applicationsets): name the agent operator Deployment for the system#25
Merged
Merged
Conversation
… system The addons-agent-operator ApplicationSet set helm releaseName: operator, so the ArgoCD Application (eks-agent-platform-operator), the helm release (operator), and the resulting Deployment (operator) had three different names — and the Deployment was a bare, generic "operator" in the namespace. Set releaseName to match the Application name so Application == release == Deployment == eks-agent-platform- operator: one fully-qualified name, consistent with the namespace and image path.
CI Results
All validations passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the addons-agent-operator AppSet helm
releaseNametoeks-agent-platform-operatorso the ArgoCD Application, helm release, and Deployment all share one fully-qualified name (was a bare, genericoperatorDeployment). Pairs with the landing-zone e2e wait-target update.