Replace checksum flags with policy option#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR replaces checksum-related Boolean CLI flags with a single checksum validation policy option, while preserving the current checksum validation behavior.
User-visible Changes
Checksum behavior is now selected with
--checksum-policy skip|warn|require.For example, allowing a direct artifact bundle URL without providing a checksum changes from a dedicated Boolean flag to an explicit policy value:
runandbootstrapstill accept the released--skip-checksum-validationflag as a hidden compatibility alias. The unreleased--allow-unverifiedand--require-checksumflags are removed from the public CLI surface.Core Changes
ChecksumValidationPolicyas the shared policy model for checksum validation.ChecksumValidationPolicyArgument.NEST_REQUIRE_CHECKSUMrequests strict validation.Details
--checksum-policy warnis the explicit allow-with-warning mode for missing checksums.--checksum-policy skipbypasses checksum validation.--checksum-policy requirerequires checksum validation and reports missing checksums as an error.NEST_REQUIRE_CHECKSUM=1still maps torequirewhen no CLI policy is provided.--checksumand--checksum-policy skipare mutually exclusive.--checksum-policy.Verification
swift testgit diff --check