|
ys_in_pad, ys_out_pad = add_sos_eos(label, self.sos, self.eos, self.ignore_id) |
|
ys_mask = target_mask(ys_in_pad, self.ignore_id) |
In
add_sos_eos function, ys_in_pad is replaced with a version padded using the eos token. Given that, should the
target_mask still be created with ignore_id? Wouldn't it make more sense to use eos as the padding value instead?
I really appreciate your work in this area. Looking forward to your clarification. Thanks!
auto_avsr/espnet/nets/pytorch_backend/e2e_asr_conformer.py
Lines 77 to 78 in 182b628
In
add_sos_eosfunction, ys_in_pad is replaced with a version padded using the eos token. Given that, should thetarget_maskstill be created with ignore_id? Wouldn't it make more sense to use eos as the padding value instead?I really appreciate your work in this area. Looking forward to your clarification. Thanks!