Skip to content

run.target: ["chromium"] ignored in config #3314

Open

Description

@fregante

Is this a feature request or a bug?

bug

What is the current behavior?

A plain $ web-ext run will read/validate webExt.run.target from my package.json, but then it ignores it.

// package.json
{
  "webExt": {
    "run": {
      "target": ["chromium"]
    }
  }
}

This verbose log line explains why: the CLI parser is providing its own defaults before merging with the config file.

[web-ext/lib/config.js][debug] Favoring CLI: target=firefox-desktop over configuration: target=chromium

What is the expected or desired behavior?

The config file should be respected by applying the defaults after reading the config file.

Version information (for bug reports)

  • Your OS and version: macOS 15.1.1
node --version && npm --version && web-ext --version
v23.1.0
10.9.0
8.3.0

Activity

  1. Rob--W commented on Dec 5, 2024

    @Rob--W
    Member

    This message is emitted from

    web-ext/src/config.js

    Lines 121 to 124 in 958e1d4

    log.debug(
    `Favoring CLI: ${option}=${argvFromCLI[option]} over ` +
    `configuration: ${option}=${configObject[option]}`,
    );
    . We probably have a bug there that we should fix.

  2. fregante commented on Dec 7, 2024

    @fregante
    ContributorAuthor

    the CLI parser is providing its own defaults before merging with the config file.

    Likely here:

    default: 'firefox-desktop',

    Yargs is passing the default the same way it would pass a user-provided flag, therefore overriding any config that is found later.

    I'd review other such defaults in the file. If they're all ignored the same way, they should probably all be removed.

    Yargs' own docs/bugtracker probably detail how to deal with configuration vs flag overrides.

  3. Rob--W commented on Jan 30, 2025

    @Rob--W
    Member

    Are you interested in contributing a patch?

  4. fregante commented on Jan 30, 2025

    @fregante
    ContributorAuthor

    I have two PRs open for 5 months over in the addons-linter repo, I'm not excited about opening more

  5. Rob--W commented on Jan 30, 2025

    @Rob--W
    Member

    I have two PRs open for 5 months over in the addons-linter repo, I'm not excited about opening more

    Apologies for that. They fell through the cracks and we missed them. We regularly triage any issues and pull requests, but sometimes an issue or PR accidentally falls off the radar. To make sure that we don't miss them again, I'll put the following tickets in the agenda for the next triage meeting (in 2 weeks):

    One of them is in a draft, which usually signals that a PR is not ready for review. Did you intend to keep it a draft?

  6. fregante commented on Jan 30, 2025

    @fregante
    ContributorAuthor

    The draft is a proposal that hasn't been accepted yet

  7. Rob--W commented on Feb 13, 2025

    @Rob--W
    Member

    @fregante We just triaged the two pull requests, thanks for raising attention to them!

  8. giri256 commented on Jul 24, 2026

    @giri256

    I’m working on a patch with regression tests so an explicit run.target from the config file is not overwritten by yargs’ default, while preserving the existing Firefox default when no target is configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions