You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have two PRs open for 5 months over in the addons-linter repo, I'm not excited about opening more
Apologies for that. They fell through the cracks and we missed them. We regularly triage any issues and pull requests, but sometimes an issue or PR accidentally falls off the radar. To make sure that we don't miss them again, I'll put the following tickets in the agenda for the next triage meeting (in 2 weeks):
I’m working on a patch with regression tests so an explicit run.target from the config file is not overwritten by yargs’ default, while preserving the existing Firefox default when no target is configured.
Activity
Rob--W commentedon Dec 5, 2024
This message is emitted from
web-ext/src/config.js
Lines 121 to 124 in 958e1d4
fregante commentedon Dec 7, 2024
Likely here:
web-ext/src/program.js
Line 583 in 64ad32f
Yargs is passing the default the same way it would pass a user-provided flag, therefore overriding any config that is found later.
I'd review other such defaults in the file. If they're all ignored the same way, they should probably all be removed.
Yargs' own docs/bugtracker probably detail how to deal with configuration vs flag overrides.
Rob--W commentedon Jan 30, 2025
Are you interested in contributing a patch?
fregante commentedon Jan 30, 2025
I have two PRs open for 5 months over in the addons-linter repo, I'm not excited about opening more
Rob--W commentedon Jan 30, 2025
Apologies for that. They fell through the cracks and we missed them. We regularly triage any issues and pull requests, but sometimes an issue or PR accidentally falls off the radar. To make sure that we don't miss them again, I'll put the following tickets in the agenda for the next triage meeting (in 2 weeks):
One of them is in a draft, which usually signals that a PR is not ready for review. Did you intend to keep it a draft?
fregante commentedon Jan 30, 2025
The draft is a proposal that hasn't been accepted yet
Rob--W commentedon Feb 13, 2025
@fregante We just triaged the two pull requests, thanks for raising attention to them!
giri256 commentedon Jul 24, 2026
I’m working on a patch with regression tests so an explicit
run.targetfrom the config file is not overwritten by yargs’ default, while preserving the existing Firefox default when no target is configured.