feat(install): support hosted tree URLs for git sources#1502
feat(install): support hosted tree URLs for git sources#1502peter-jerry-ye wants to merge 7 commits intomainfrom
Conversation
Changed Files
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6df4219ddb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let (branch, path_in_repo) = if after_tree.len() == 1 { | ||
| (Some(after_tree[0].to_string()), None) | ||
| } else { | ||
| ( | ||
| Some(after_tree[0].to_string()), |
There was a problem hiding this comment.
Handle slash-containing refs in hosted tree URLs
This parser assumes the ref is always after_tree[0], so URLs like .../tree/feature/new-ui (a valid branch/tag name containing /) are misinterpreted as ref feature plus path_in_repo new-ui. In that case moon install will either check out the wrong ref or fail with a missing-path error, even though the copied hosted tree URL is valid; this affects common branch naming conventions such as feature/... and release/....
Useful? React with 👍 / 👎.
f65b0b1 to
7f52d3f
Compare
Summary
Supported source forms
Notes
This PR is stacked on top of PR #1501 and should be reviewed after it.
Testing