FP104: respect React Native module removal versions (#1878)

* fix: respect React Native module removal versions

* fix: retain reports for unbounded native version ranges

Author: aidenybai

.changeset/fp104-native-module-versions.md

@@ -0,0 +1,7 @@
+---
+"oxlint-plugin-react-doctor": patch
+"eslint-plugin-react-doctor": patch
+"react-doctor": patch
+---
+
+Respect the installed or declared React Native version before reporting removed AsyncStorage and WebView exports. Reuse package-version resolution and track manifests for diagnostic cache invalidation.

packages/core/tests/cross-file-rule-ids.test.ts

@@ -242,6 +242,7 @@ describe("CROSS_FILE_RULE_IDS", () => {
       "rendering-hydration-mismatch-time",
       "rendering-hydration-no-flicker",
       "rerender-memo-with-default-value",
+      "rn-no-deprecated-modules",
       "rn-no-legacy-shadow-styles",
       "rn-no-raw-text",
       "rn-prefer-expo-image",

packages/fuzz/corpus/regressions/rn-no-deprecated-modules--legacy-version/component.tsx

@@ -0,0 +1,3 @@
+import { AsyncStorage, WebView } from "react-native";
+export const Browser = () => <WebView />;
+export const load = () => AsyncStorage.getItem("session");

packages/fuzz/corpus/regressions/rn-no-deprecated-modules--legacy-version/package.json

@@ -0,0 +1,6 @@
+{
+  "private": true,
+  "dependencies": {
+    "react-native": "0.55.4"
+  }
+}

packages/oxlint-plugin-react-doctor/src/plugin/constants/cross-file-rule-ids.ts

@@ -83,6 +83,7 @@ export const CROSS_FILE_RULE_IDS: ReadonlySet<string> = new Set([
   "remotion-no-next-image",
   "rerender-memo-with-default-value",
   "server-sequential-independent-await",
+  "rn-no-deprecated-modules",
   "rn-no-legacy-shadow-styles",
   "rn-no-raw-text",
   "rn-prefer-expo-image",

packages/oxlint-plugin-react-doctor/src/plugin/constants/react-native.ts

@@ -176,3 +176,11 @@ export const LEGACY_SHADOW_STYLE_PROPERTIES = new Set([
   "shadowRadius",
   "elevation",
 ]);
+
+export const REACT_NATIVE_MODULE_REMOVAL_MINOR: ReadonlyMap<string, number> = new Map([
+  ["WebView", 60],
+  ["AsyncStorage", 71],
+]);
+
+export const REACT_NATIVE_SINGLE_MINOR_RANGE_PATTERN =
+  /^[~^=v]?\s*0\.\d+(?:\.(?:\d+|[xX*]))?(?:-[0-9A-Za-z.-]+)?(?:\+[0-9A-Za-z.-]+)?$/;

packages/oxlint-plugin-react-doctor/src/plugin/cross-file-dependencies.test.ts

@@ -879,3 +879,20 @@ describe("collector registry", () => {
     ).toEqual([...CROSS_FILE_RULE_IDS].sort());
   });
 });
+
+describe("React Native export version dependencies", () => {
+  it("records the installed native manifest on cold and warm collection", () => {
+    writeFixtureFile("package.json", `{ "dependencies": { "react-native": "0.40.0" } }`);
+    writeFixtureFile(
+      "node_modules/react-native/package.json",
+      `{ "name": "react-native", "version": "0.71.0" }`,
+    );
+    const appPath = writeFixtureFile("src/App.tsx", `import { AsyncStorage } from 'react-native';`);
+    const coldTrace = collectFor(appPath, ["rn-no-deprecated-modules"]);
+    const warmTrace = collectFor(appPath, ["rn-no-deprecated-modules"]);
+    expect(coldTrace?.contentPaths.has(fixturePath("node_modules/react-native/package.json"))).toBe(
+      true,
+    );
+    expect(warmTrace?.contentPaths).toEqual(coldTrace?.contentPaths);
+  });
+});

packages/oxlint-plugin-react-doctor/src/plugin/cross-file-dependencies.ts

@@ -1,3 +1,4 @@
+import { resolvePackageVersion } from "./utils/resolve-package-version.js";
 import type { StaticImport } from "oxc-parser";
 import { analyzeScopes } from "./semantic/scope-analysis.js";
 import { awaitedStatementsMayShareWork } from "./utils/awaited-statements-may-share-work.js";
@@ -531,6 +532,12 @@ const collectLegacyArchDependencies: CrossFileDependencyCollector = ({ absoluteF
   isLegacyArchReactNativeFile(absoluteFilePath);
 };
 
+const collectReactNativeVersionDependencies: CrossFileDependencyCollector = ({
+  absoluteFilePath,
+}) => {
+  resolvePackageVersion(absoluteFilePath, "react-native");
+};
+
 const collectInkVersionDependencies: CrossFileDependencyCollector = ({ absoluteFilePath }) => {
   resolveInkVersion(absoluteFilePath);
 };
@@ -582,6 +589,7 @@ export const CROSS_FILE_DEPENDENCY_COLLECTORS: ReadonlyMap<string, CrossFileDepe
     ["rendering-hydration-no-flicker", collectEffectValueHelperDependencies],
     ["rerender-memo-with-default-value", collectForwardedHookDependencies],
     ["server-sequential-independent-await", collectSequentialAwaitDependencies],
+    ["rn-no-deprecated-modules", collectReactNativeVersionDependencies],
     ["rn-no-legacy-shadow-styles", collectLegacyArchDependencies],
     ["rn-no-raw-text", collectRnNoRawTextDependencies],
     ["rn-prefer-expo-image", collectNearestManifestDependencies],

packages/oxlint-plugin-react-doctor/src/plugin/rules/react-native/rn-no-deprecated-modules.ts

@@ -1,4 +1,9 @@
-import { DEPRECATED_RN_MODULE_REPLACEMENTS } from "../../constants/react-native.js";
+import { resolvePackageVersion } from "../../utils/resolve-package-version.js";
+import {
+  DEPRECATED_RN_MODULE_REPLACEMENTS,
+  REACT_NATIVE_MODULE_REMOVAL_MINOR,
+  REACT_NATIVE_SINGLE_MINOR_RANGE_PATTERN,
+} from "../../constants/react-native.js";
 import { defineRule } from "../../utils/define-rule.js";
 import { isTypeOnlyImport } from "../../utils/is-type-only-import.js";
 import type { RuleContext } from "../../utils/rule-context.js";
@@ -27,6 +32,17 @@ export const rnNoDeprecatedModules = defineRule({
 
         const baseReplacement = DEPRECATED_RN_MODULE_REPLACEMENTS.get(importedName);
         if (!baseReplacement) continue;
+        const removalMinor = REACT_NATIVE_MODULE_REMOVAL_MINOR.get(importedName);
+        if (removalMinor !== undefined) {
+          const resolvedVersion = resolvePackageVersion(context.filename, "react-native");
+          if (
+            resolvedVersion?.version.major === 0 &&
+            resolvedVersion.version.minor < removalMinor &&
+            (resolvedVersion.declaredRange === null ||
+              REACT_NATIVE_SINGLE_MINOR_RANGE_PATTERN.test(resolvedVersion.declaredRange.trim()))
+          )
+            continue;
+        }
 
         context.report({
           node: specifier,

packages/oxlint-plugin-react-doctor/src/plugin/rules/react-native/rn-removed-module-versions.test.ts

@@ -0,0 +1,63 @@
+import * as fs from "node:fs";
+import * as os from "node:os";
+import * as path from "node:path";
+import { afterEach, beforeEach, describe, expect, it } from "vite-plus/test";
+import { runRule } from "../../../test-utils/run-rule.js";
+import { resetManifestCaches } from "../../utils/read-nearest-package-manifest.js";
+import { rnNoDeprecatedModules } from "./rn-no-deprecated-modules.js";
+
+let temporaryDirectory = "";
+const checkImport = (moduleName: string, declaredVersion: string, installedVersion?: string) => {
+  fs.writeFileSync(
+    path.join(temporaryDirectory, "package.json"),
+    JSON.stringify({ dependencies: { "react-native": declaredVersion } }),
+  );
+  if (installedVersion) {
+    const packageDirectory = path.join(temporaryDirectory, "node_modules", "react-native");
+    fs.mkdirSync(packageDirectory, { recursive: true });
+    fs.writeFileSync(
+      path.join(packageDirectory, "package.json"),
+      JSON.stringify({ name: "react-native", version: installedVersion }),
+    );
+  }
+  return runRule(rnNoDeprecatedModules, `import { ${moduleName} } from 'react-native';`, {
+    filename: path.join(temporaryDirectory, "app.tsx"),
+  });
+};
+
+describe("removed React Native export versions", () => {
+  beforeEach(() => {
+    temporaryDirectory = fs.mkdtempSync(path.join(os.tmpdir(), "rd-native-exports-"));
+    resetManifestCaches();
+  });
+  afterEach(() => fs.rmSync(temporaryDirectory, { recursive: true, force: true }));
+
+  it.each([
+    ["AsyncStorage", "^0.40.0"],
+    ["AsyncStorage", "0.41.2"],
+    ["AsyncStorage", "0.50.3"],
+    ["AsyncStorage", "0.70.0"],
+    ["WebView", "0.55.4"],
+    ["WebView", "0.59.10"],
+    ["WebView", "~0.59.0"],
+    ["WebView", "0.59.x"],
+  ])("accepts %s before removal in %s", (moduleName, version) => {
+    expect(checkImport(moduleName, version).diagnostics).toHaveLength(0);
+  });
+
+  it.each([
+    ["AsyncStorage", "0.71.0"],
+    ["WebView", "0.60.0"],
+    ["WebView", ">=0.55.0"],
+    ["AsyncStorage", "0.55.0 || 0.71.0"],
+  ])("reports %s once removed in %s", (moduleName, version) => {
+    expect(checkImport(moduleName, version).diagnostics).toHaveLength(1);
+  });
+
+  it("uses the installed version instead of an older declaration", () => {
+    expect(checkImport("AsyncStorage", "0.40.0", "0.71.0").diagnostics).toHaveLength(1);
+  });
+  it("uses the installed version instead of a newer declaration", () => {
+    expect(checkImport("AsyncStorage", "0.71.0", "0.41.2").diagnostics).toHaveLength(0);
+  });
+});