Skip to content

[DatePicker] Prevent silently ignoring date formatting failures #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tyme-Bleyaert wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

[DatePicker] Prevent silently ignoring date formatting failures #4496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f195aa1
Prevent silently ignoring date formatting failures
Tyme-Bleyaert Jan 29, 2026
ca35db0
Merge branch 'dev' into fix/date-input/prevent-ignore-format-fails
vnbaaij Jan 30, 2026
182e79e
Add extra test, refactor ParsingErrorMessage property for all fields.
Tyme-Bleyaert Jan 30, 2026
57de5f5
Merge branch 'fix/date-input/prevent-ignore-format-fails' of https://…
Tyme-Bleyaert Jan 30, 2026
f863b7a
Attempt to fix culture comparison on the pipeline for failing tests.
Tyme-Bleyaert Jan 30, 2026
053aa4c
Remove using that somehow got introduced.
Tyme-Bleyaert Jan 30, 2026
998a876
Run test against protected method instead of extension method *Facepa…
Tyme-Bleyaert Jan 30, 2026
6d5fa8a
Fix copy paste issue
Tyme-Bleyaert Jan 30, 2026
ec6cb1e
Move parsing away from input base.
Tyme-Bleyaert Feb 1, 2026
5e72175
Merge branch 'dev' into fix/date-input/prevent-ignore-format-fails
dvoituron Feb 1, 2026
b356e92
Revert "Move parsing away from input base."
Tyme-Bleyaert Feb 1, 2026
d3fe697
Merge branch 'fix/date-input/prevent-ignore-format-fails' of https://…
Tyme-Bleyaert Feb 1, 2026
aff36e0
Merge branch 'dev' into fix/date-input/prevent-ignore-format-fails
vnbaaij Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,11 @@
If true, the ClassValue property will not include the EditContext's FieldCssClass.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1.ParsingErrorMessage">
<summary>
Gets or sets the error message to show when the field can not be parsed.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1.EditContext">
<summary>
Gets the associated <see cref="T:Microsoft.AspNetCore.Components.Forms.EditContext"/>.
Expand All @@ -669,6 +674,12 @@
Gets the <see cref="P:Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1.FieldIdentifier"/> for the bound value.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1.FieldDisplayName">
<summary>
Gets the display name of the field, using the specified display name if set; otherwise, uses the field
identifier's name if the field is bound.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1.CurrentValue">
<summary>
Gets or sets the current value of the input.
Expand Down Expand Up @@ -8127,11 +8138,6 @@
An Id value must be set to use this property.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1.ParsingErrorMessage">
<summary>
Gets or sets the error message to show when the field can not be parsed.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1.ChildContent">
<summary>
Gets or sets the content to be rendered inside the component.
Expand All @@ -8143,6 +8149,11 @@
unless an explicit value for Min or Max is provided.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1.ParsingErrorMessage">
<summary>
Gets or sets the error message to show when the field can not be parsed.
</summary>
</member>
<member name="M:Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1.FormatValueAsString(`0)">
<summary>
Formats the value as a string. Derived classes can override this to determine the formatting used for <c>CurrentValueAsString</c>.
Expand Down Expand Up @@ -9091,6 +9102,11 @@
Fires when hovered value changes. Value will be null if no rating item is hovered.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentRating.ParsingErrorMessage">
<summary>
Gets or sets the error message to show when the field can not be parsed.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentRating.GroupName">
<summary />
</member>
Expand Down
12 changes: 12 additions & 0 deletions src/Core/Components/Base/FluentInputBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,12 @@ public abstract partial class FluentInputBase<TValue> : FluentComponentBase, IDi
[Parameter]
public virtual bool Embedded { get; set; } = false;

/// <summary>
/// Gets or sets the error message to show when the field can not be parsed.
/// </summary>
[Parameter]
public virtual string ParsingErrorMessage { get; set; } = "The {0} field must have a valid format.";

/// <summary>
/// Gets the associated <see cref="Microsoft.AspNetCore.Components.Forms.EditContext"/>.
/// This property is uninitialized if the input does not have a parent <see cref="EditForm"/>.
Expand All @@ -145,6 +151,12 @@ public abstract partial class FluentInputBase<TValue> : FluentComponentBase, IDi

internal virtual bool FieldBound => Field is not null || ValueExpression is not null || ValueChanged.HasDelegate;

/// <summary>
/// Gets the display name of the field, using the specified display name if set; otherwise, uses the field
/// identifier's name if the field is bound.
/// </summary>
internal string FieldDisplayName => DisplayName ?? (FieldBound ? FieldIdentifier.FieldName : UnknownBoundField);

protected async Task SetCurrentValueAsync(TValue? value)
{
var hasChanged = !EqualityComparer<TValue>.Default.Equals(value, Value);
Expand Down
6 changes: 3 additions & 3 deletions src/Core/Components/DateTime/FluentCalendar.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,9 @@ private async Task PickerYearSelectAsync(DateTime? year)
/// <summary />
protected override bool TryParseValueFromString(string? value, out DateTime? result, [NotNullWhen(false)] out string? validationErrorMessage)
{
BindConverter.TryConvertTo(value, Culture, out result);
validationErrorMessage = null;
return true;
bool success = BindConverter.TryConvertTo(value, Culture, out result);
validationErrorMessage = success ? null : string.Format(ParsingErrorMessage, FieldDisplayName);
return success;
}

/// <summary />
Expand Down
7 changes: 3 additions & 4 deletions src/Core/Components/DateTime/FluentDatePicker.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,9 @@ protected override bool TryParseValueFromString(string? value, out DateTime? res
value = new DateTime(year, 1, 1).ToString(Culture.DateTimeFormat.ShortDatePattern);
}

BindConverter.TryConvertTo(value, Culture, out result);

validationErrorMessage = null;
return true;
bool success = BindConverter.TryConvertTo(value, Culture, out result);
validationErrorMessage = success ? null : string.Format(ParsingErrorMessage, FieldDisplayName);
return success;
}

private string PlaceholderAccordingToView()
Expand Down
11 changes: 5 additions & 6 deletions src/Core/Components/NumberField/FluentNumberField.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@ public partial class FluentNumberField<TValue> : FluentInputBase<TValue>, IAsync
[Parameter]
public string? AutoComplete { get; set; }

/// <summary>
/// Gets or sets the error message to show when the field can not be parsed.
/// </summary>
[Parameter]
public string ParsingErrorMessage { get; set; } = "The {0} field must be a (valid) number.";

/// <summary>
/// Gets or sets the content to be rendered inside the component.
/// </summary>
Expand All @@ -105,6 +99,11 @@ public partial class FluentNumberField<TValue> : FluentInputBase<TValue>, IAsync
[Parameter]
public bool UseTypeConstraints { get; set; }

/// <summary>
/// Gets or sets the error message to show when the field can not be parsed.
/// </summary>
public override string ParsingErrorMessage { get; set; } = "The {0} field must be a (valid) number.";

private static readonly string _stepAttributeValue = GetStepAttributeValue();

// If type constraints is true and min is null, set min to the minimum value of TValue.
Expand Down
8 changes: 6 additions & 2 deletions src/Core/Components/Rating/FluentRating.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ public partial class FluentRating : FluentInputBase<int>
[Parameter]
public EventCallback<int?> OnHoverValueChanged { get; set; }

/// <summary>
/// Gets or sets the error message to show when the field can not be parsed.
/// </summary>
public override string ParsingErrorMessage { get; set; } = "The {0} field must be a number.";

/// <summary />
private string GroupName => Id ?? $"rating-{Id}";

Expand All @@ -90,8 +95,7 @@ protected override bool TryParseValueFromString(string? value, [MaybeNullWhen(fa
}
else
{
validationErrorMessage = string.Format(CultureInfo.InvariantCulture,
"The {0} field must be a number.",
validationErrorMessage = string.Format(ParsingErrorMessage,
FieldBound ? FieldIdentifier.FieldName : UnknownBoundField);
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Core/Extensions/FluentInputExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal static class FluentInputExtensions
}

result = default;
validationErrorMessage = $"The {input.DisplayName ?? (input.FieldBound ? input.FieldIdentifier.FieldName : input.UnknownBoundField)} field is not valid.";
validationErrorMessage = string.Format(input.ParsingErrorMessage, input.FieldDisplayName);
return false;
}
catch (InvalidOperationException ex)
Expand Down
39 changes: 39 additions & 0 deletions tests/Core/DateTime/FluentDatePickerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// This file is licensed to you under the MIT License.
// ------------------------------------------------------------------------

using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using Bunit;
using Microsoft.AspNetCore.Components;
Expand Down Expand Up @@ -292,4 +293,42 @@ public void FluentDatePicker_OnDoubleClickEventTriggers()
// Assert
Assert.Equal(expected, actual);
}

[Theory]
[InlineData("02-22-2000", "en-GB", "02/22/2000")]
[InlineData("02-22-2000", "nl-BE", null)]
[InlineData("22-12-2000", "nl-BE", "22/12/2000")]
[InlineData("02/22/2000", "en-GB", "02/22/2000")]
[InlineData("abc", "en-GB", null)]
[InlineData("02022000", "en-GB", null)]
public void FluentDatePicker_TryParseValueFromString(string? value, string? cultureName, string? expectedValue)
{
// Arrange
var picker = new TestDatePicker();
var culture = cultureName != null ? CultureInfo.GetCultureInfo(cultureName) : CultureInfo.InvariantCulture;

// Act
picker.Culture = culture;
var successfullParse = picker.CallTryParseValueFromString(value, out var resultDate, out var validationErrorMessage);

// Assert
if (successfullParse)
{
Assert.Equal(expectedValue, resultDate?.ToString(culture.DateTimeFormat.ShortDatePattern, culture));
}
else
{
Assert.Null(resultDate);
Assert.NotNull(validationErrorMessage);
}
}

// Temporary class to expose protected method
private class TestDatePicker : FluentDatePicker
{
public bool CallTryParseValueFromString(string? value, out System.DateTime? result, [NotNullWhen(false)] out string? validationErrorMessage)
{
return base.TryParseValueFromString(value, out result, out validationErrorMessage);
}
}
}
Loading