Skip to content

Commit b4850ce

Browse files
committed
fix(minimax): wire YAML / CLI config through to backend
PR #26 added a MiniMax chat backend but left three loose ends that silently dropped any YAML / CLI configuration of minimax_* keys: only the environment-variable path worked. - skillopt/config.py: add 6 model.minimax_* entries to _FLATTEN_MAP so the keys declared in configs/_base_/default.yaml actually survive flatten_config() (mirroring the existing model.qwen_chat_* block). - skillopt/engine/trainer.py: import configure_minimax_chat and call it alongside configure_qwen_chat, so cfg-supplied credentials, temperature, max_tokens, and enable_thinking reach the backend. Also apply cfg["minimax_model"] via set_target_deployment when the active target backend is minimax_chat. - scripts/train.py: add 6 --minimax_* CLI flags + the corresponding _CLI_TO_YAML entries, add 'minimax' / 'minimax_chat' to the --backend choices, auto-route to target_backend=minimax_chat, and pick the right default target_model for the new backend. Default behavior on existing backends (openai, claude, qwen, codex, claude_code_exec) is unchanged; all 8 shipped configs continue to load with gate_metric falling back to 'hard' for paper reproduction.
1 parent 643346c commit b4850ce

3 files changed

Lines changed: 42 additions & 1 deletion

File tree

‎scripts/train.py‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def parse_args() -> argparse.Namespace:
137137
# Legacy flat CLI overrides (still work, prefer --cfg-options for new usage)
138138
p.add_argument("--env", type=str)
139139
p.add_argument("--backend", type=str,
140-
choices=["azure_openai", "codex", "codex_exec", "claude", "claude_chat", "claude_code_exec", "qwen", "qwen_chat"])
140+
choices=["azure_openai", "codex", "codex_exec", "claude", "claude_chat", "claude_code_exec", "qwen", "qwen_chat", "minimax", "minimax_chat"])
141141
p.add_argument("--optimizer_model", type=str)
142142
p.add_argument("--target_model", type=str)
143143
p.add_argument("--optimizer_backend", type=str)
@@ -173,6 +173,12 @@ def parse_args() -> argparse.Namespace:
173173
p.add_argument("--qwen_chat_timeout_seconds", type=float)
174174
p.add_argument("--qwen_chat_max_tokens", type=int)
175175
p.add_argument("--qwen_chat_enable_thinking", type=_BOOL)
176+
p.add_argument("--minimax_base_url", type=str)
177+
p.add_argument("--minimax_api_key", type=str)
178+
p.add_argument("--minimax_model", type=str)
179+
p.add_argument("--minimax_temperature", type=float)
180+
p.add_argument("--minimax_max_tokens", type=int)
181+
p.add_argument("--minimax_enable_thinking", type=_BOOL)
176182
p.add_argument("--codex_exec_path", type=str)
177183
p.add_argument("--codex_exec_sandbox", type=str)
178184
p.add_argument("--codex_exec_profile", type=str)
@@ -289,6 +295,12 @@ def parse_args() -> argparse.Namespace:
289295
"qwen_chat_timeout_seconds": "model.qwen_chat_timeout_seconds",
290296
"qwen_chat_max_tokens": "model.qwen_chat_max_tokens",
291297
"qwen_chat_enable_thinking": "model.qwen_chat_enable_thinking",
298+
"minimax_base_url": "model.minimax_base_url",
299+
"minimax_api_key": "model.minimax_api_key",
300+
"minimax_model": "model.minimax_model",
301+
"minimax_temperature": "model.minimax_temperature",
302+
"minimax_max_tokens": "model.minimax_max_tokens",
303+
"minimax_enable_thinking": "model.minimax_enable_thinking",
292304
"codex_exec_path": "model.codex_exec_path",
293305
"codex_exec_sandbox": "model.codex_exec_sandbox",
294306
"codex_exec_profile": "model.codex_exec_profile",
@@ -403,6 +415,9 @@ def _has_model_override(dotted_key: str, legacy_key: str) -> bool:
403415
elif backend in {"qwen", "qwen_chat"}:
404416
flat.setdefault("optimizer_backend", "openai_chat")
405417
flat.setdefault("target_backend", "qwen_chat")
418+
elif backend in {"minimax", "minimax_chat"}:
419+
flat.setdefault("optimizer_backend", "openai_chat")
420+
flat.setdefault("target_backend", "minimax_chat")
406421
else:
407422
flat.setdefault("optimizer_backend", "openai_chat")
408423
flat.setdefault("target_backend", "openai_chat")
@@ -434,6 +449,15 @@ def _has_model_override(dotted_key: str, legacy_key: str) -> bool:
434449
and not _has_model_override("model.target", "target_model")
435450
):
436451
flat["target_model"] = default_model_for_backend("qwen_chat")
452+
if flat.get("target_backend") == "minimax_chat":
453+
if (
454+
str(flat.get("target_model", "") or "").strip() in _OPENAI_DEFAULT_MODEL_SENTINELS
455+
and not _has_model_override("model.target", "target_model")
456+
):
457+
flat["target_model"] = (
458+
flat.get("minimax_model")
459+
or default_model_for_backend("minimax_chat")
460+
)
437461

438462
# Auto-generate output root
439463
if not flat.get("out_root"):

‎skillopt/config.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,12 @@
7979
"model.qwen_chat_timeout_seconds": "qwen_chat_timeout_seconds",
8080
"model.qwen_chat_max_tokens": "qwen_chat_max_tokens",
8181
"model.qwen_chat_enable_thinking": "qwen_chat_enable_thinking",
82+
"model.minimax_base_url": "minimax_base_url",
83+
"model.minimax_api_key": "minimax_api_key",
84+
"model.minimax_model": "minimax_model",
85+
"model.minimax_temperature": "minimax_temperature",
86+
"model.minimax_max_tokens": "minimax_max_tokens",
87+
"model.minimax_enable_thinking": "minimax_enable_thinking",
8288
"train.num_epochs": "num_epochs",
8389
"train.train_size": "train_size",
8490
"train.steps_per_epoch": "steps_per_epoch",

‎skillopt/engine/trainer.py‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
configure_azure_openai,
5252
configure_claude_code_exec,
5353
configure_codex_exec,
54+
configure_minimax_chat,
5455
configure_qwen_chat,
5556
get_token_summary,
5657
reset_token_tracker,
@@ -636,6 +637,16 @@ def _build_eval_env(split: str, env_num: int, seed: int):
636637
max_tokens=cfg.get("qwen_chat_max_tokens"),
637638
enable_thinking=cfg.get("qwen_chat_enable_thinking"),
638639
)
640+
configure_minimax_chat(
641+
base_url=cfg.get("minimax_base_url") or None,
642+
api_key=cfg.get("minimax_api_key") or None,
643+
temperature=cfg.get("minimax_temperature"),
644+
max_tokens=cfg.get("minimax_max_tokens"),
645+
enable_thinking=cfg.get("minimax_enable_thinking"),
646+
)
647+
minimax_model_cfg = cfg.get("minimax_model")
648+
if minimax_model_cfg and cfg.get("target_backend") == "minimax_chat":
649+
set_target_deployment(str(minimax_model_cfg))
639650
os.environ["REFLACT_CODEX_TRACE_TO_OPTIMIZER"] = (
640651
"1"
641652
if target_backend == "codex_exec" and cfg.get("codex_trace_to_optimizer", False)

0 commit comments

Comments
 (0)