fix: keep shared server config when deleting one of multiple contexts#422
Open
Syedowais312 wants to merge 1 commit into
Open
fix: keep shared server config when deleting one of multiple contexts#422Syedowais312 wants to merge 1 commit into
Syedowais312 wants to merge 1 commit into
Conversation
Signed-off-by: syedowais312 <syedowais312sf@gmail.com>
5935b10 to
68a921e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes context deletion when multiple contexts reference the same server entry.
If the config contains a single server and multiple contexts pointing to it,
deleting one context could also remove shared metadata that was still needed by the
remaining context.
Changes
user,server,auth, andinstanceentries only when noremaining context references them
Reproducer
Testing
go test ./cmd ./pkg/configcloses: #421