Skip to content

[TODO] Clean up repository #3

Description

@mrousavy

We need to clean up the repository a bit.

  1. Move everything into a package/ or packages/react-native-nitro-fetch folder so the root is clean (file list is too long, we can't see the README on first glance - check out https://github.com/mrousavy/nitro for reference)
  2. Remove the git commit hooks - those suck. Instead, move them into CI. See https://github.com/mrousavy/nitro/tree/main/.github/workflows
    • Add CI actions to run typescript & nitrogen
    • Add CI actions to build the example app
  3. Remove any dependencies that we don't use (e.g. commitlint)
  4. Add cleaner issue templates like in Nitro (e.g.: https://github.com/mrousavy/nitro/tree/main/.github/ISSUE_TEMPLATE)
  5. Migrate to a monorepo (bun?)
  6. Remove all prepare_....sh scripts for Cronet downloads as those are unused (it should be in Gradle scripts so contributors dont have to run extra scripts when they want to clone the repo)
  7. Migrate away from MMKV to NSUserDefaults/SharedPreferences (MMKV is not needed and could break, let's keep it simple!)
  8. Remove // @ts-ignore statements and actually make the types sound (no as casts, instead do safe type casts - otherwise this will break in the future)
  9. Remove console.warn if something is not available (e.g. react-native-mmkv import), instead expose something like supportsPrefetching (we don't need that since it always works once we migrate away from MMKV)
  10. Remove all console.logs - those were probably for debugging only. Any errors should be throw new Error(...)
  11. Refactor all any / unknown types to at least something more concrete (e.g. interface Worklets { runOnJS(..): void } instead of just having it any)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions