You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move everything into a package/ or packages/react-native-nitro-fetch folder so the root is clean (file list is too long, we can't see the README on first glance - check out https://github.com/mrousavy/nitro for reference)
Remove all prepare_....sh scripts for Cronet downloads as those are unused (it should be in Gradle scripts so contributors dont have to run extra scripts when they want to clone the repo)
Migrate away from MMKV to NSUserDefaults/SharedPreferences (MMKV is not needed and could break, let's keep it simple!)
Remove // @ts-ignore statements and actually make the types sound (no as casts, instead do safe type casts - otherwise this will break in the future)
Remove console.warn if something is not available (e.g. react-native-mmkv import), instead expose something like supportsPrefetching (we don't need that since it always works once we migrate away from MMKV)
Remove all console.logs - those were probably for debugging only. Any errors should be throw new Error(...)
Refactor all any / unknown types to at least something more concrete (e.g. interface Worklets { runOnJS(..): void } instead of just having it any)
We need to clean up the repository a bit.
package/orpackages/react-native-nitro-fetchfolder so the root is clean (file list is too long, we can't see the README on first glance - check out https://github.com/mrousavy/nitro for reference)prepare_....shscripts for Cronet downloads as those are unused (it should be in Gradle scripts so contributors dont have to run extra scripts when they want to clone the repo)NSUserDefaults/SharedPreferences(MMKV is not needed and could break, let's keep it simple!)// @ts-ignorestatements and actually make the types sound (noascasts, instead do safe type casts - otherwise this will break in the future)console.warnif something is not available (e.g.react-native-mmkvimport), instead expose something likesupportsPrefetching(we don't need that since it always works once we migrate away from MMKV)console.logs - those were probably for debugging only. Any errors should bethrow new Error(...)any/unknowntypes to at least something more concrete (e.g.interface Worklets { runOnJS(..): void }instead of just having itany)