chore: use ini stringify

Author: davidturnbull

packages/cli/src/cli/utils/settings.ts

@@ -3,7 +3,7 @@ import path from "path";
 import _ from "lodash";
 import Z from "zod";
 import fs from "fs";
-import { getRcConfig } from "@lingo.dev/config";
+import { getRcConfig, saveRcConfig } from "@lingo.dev/config";
 import { PROVIDER_METADATA } from "@lingo.dev/providers";
 
 export type CliSettings = Z.infer<typeof SettingsSchema>;
@@ -131,30 +131,7 @@ function _loadSystemFile() {
 }
 
 function _saveSystemFile(settings: CliSettings) {
-  const settingsFilePath = _getSettingsFilePath();
-  const llmEntries: string[] = [];
-  for (const meta of Object.values(PROVIDER_METADATA)) {
-    const cfgKey = meta.apiKeyConfigKey;
-    if (!cfgKey) continue;
-    const suffix = cfgKey.startsWith("llm.") ? cfgKey.slice(4) : undefined;
-    if (!suffix) continue;
-    const value = (settings.llm as any)?.[suffix];
-    if (value) llmEntries.push(`${suffix}=${value}`);
-  }
-
-  const content = [
-    `[auth]`,
-    `apiKey=${settings.auth.apiKey}`,
-    `apiUrl=${settings.auth.apiUrl}`,
-    `webUrl=${settings.auth.webUrl}`,
-    ``,
-    `[llm]`,
-    ...llmEntries,
-    ``,
-  ]
-    .filter(Boolean)
-    .join("\n");
-  fs.writeFileSync(settingsFilePath, content);
+  saveRcConfig(settings);
 }
 
 function _getSettingsFilePath(): string {

packages/config/src/index.spec.ts

@@ -1,7 +1,60 @@
-import { describe, it, expect } from "vitest";
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { saveRcConfig, getRcConfig } from "./index";
+import fs from "fs";
+import os from "os";
+import path from "path";
+
+vi.mock("fs");
+vi.mock("os");
 
 describe("config package", () => {
-  it("loads without tests", () => {
-    expect(true).toBe(true);
+  beforeEach(() => {
+    vi.clearAllMocks();
+    vi.mocked(os.homedir).mockReturnValue("/mock/home");
+  });
+
+  it("saveRcConfig uses Ini.stringify", () => {
+    const mockWrite = vi.mocked(fs.writeFileSync);
+
+    saveRcConfig({
+      auth: {
+        apiKey: "test-key",
+        apiUrl: "https://test.com",
+        webUrl: "https://web.test.com",
+      },
+      llm: {
+        openaiApiKey: "openai-key",
+      },
+    });
+
+    expect(mockWrite).toHaveBeenCalledWith(
+      path.join("/mock/home", ".lingodotdevrc"),
+      expect.stringContaining("[auth]")
+    );
+    expect(mockWrite).toHaveBeenCalledWith(
+      path.join("/mock/home", ".lingodotdevrc"),
+      expect.stringContaining("[llm]")
+    );
+  });
+
+  it("saveRcConfig handles undefined values gracefully", () => {
+    const mockWrite = vi.mocked(fs.writeFileSync);
+
+    saveRcConfig({
+      auth: {
+        apiKey: "test-key",
+      },
+      llm: {
+        openaiApiKey: undefined,
+        anthropicApiKey: "defined-key",
+      },
+    });
+
+    expect(mockWrite).toHaveBeenCalled();
+    const writtenContent = mockWrite.mock.calls[0][1] as string;
+
+    // Ini.stringify should omit undefined values, not write "undefined"
+    expect(writtenContent).not.toContain("undefined");
+    expect(writtenContent).toContain("anthropicApiKey");
   });
 });

packages/config/src/index.ts

@@ -31,3 +31,20 @@ export function getRcConfig(): RcConfig {
   const data = Ini.parse(content);
   return rcConfigSchema.parse(data);
 }
+
+function removeUndefined<T>(obj: T): T {
+  if (obj === null || typeof obj !== "object") return obj;
+  if (Array.isArray(obj)) return obj.map(removeUndefined) as T;
+  return Object.fromEntries(
+    Object.entries(obj)
+      .filter(([_, v]) => v !== undefined)
+      .map(([k, v]) => [k, removeUndefined(v)])
+  ) as T;
+}
+
+export function saveRcConfig(config: RcConfig): void {
+  const settingsFilePath = getSettingsFilePath();
+  // Ini.stringify writes literal "undefined" strings, so filter them out first
+  const content = Ini.stringify(removeUndefined(config));
+  fs.writeFileSync(settingsFilePath, content);
+}