Merge pull request #2793 from tisnik/lcore-4342-cache-benchmarks-stub

LCORE-4342: cache benchmarks stub

Author: tisnik

tests/benchmarks/cache_data.py

@@ -0,0 +1,25 @@
+"""Data used by cache benchmarks."""
+
+from cache.cache_entry import CacheEntry
+from utils import suid
+
+USER_ID = suid.get_suid()
+CONVERSATION_ID_1 = suid.get_suid()
+CONVERSATION_ID_2 = suid.get_suid()
+USER_PROVIDED_USER_ID = "test-user1"
+cache_entry_1 = CacheEntry(
+    query="user message1",
+    response="AI message1",
+    provider="foo",
+    model="bar",
+    started_at="2025-10-03T09:31:25Z",
+    completed_at="2025-10-03T09:31:29Z",
+)
+cache_entry_2 = CacheEntry(
+    query="user message2",
+    response="AI message2",
+    provider="foo",
+    model="bar",
+    started_at="2025-10-03T09:31:25Z",
+    completed_at="2025-10-03T09:31:29Z",
+)

tests/benchmarks/conftest.py

@@ -6,6 +6,7 @@
 import pytest
 
 from app import database
+from cache.noop_cache import NoopCache
 from configuration import AppConfig, configuration
 
 
@@ -125,3 +126,17 @@ def postgres_database_fixture(configuration_filename_postgres: str) -> None:
     # initialize database session and create tables
     database.initialize_database()
     database.create_tables()
+
+
+@pytest.fixture(name="noop_cache_fixture")
+def noop_cache() -> NoopCache:
+    """Fixture with constructed and initialized in memory cache object.
+
+    Create and initialize an in-memory NoopCache for use as a test fixture.
+
+    Returns:
+        NoopCache: An initialized NoopCache instance ready for tests.
+    """
+    c = NoopCache()
+    c.initialize_cache()
+    return c

tests/benchmarks/test_cache_connect.py

@@ -0,0 +1,10 @@
+"""Benchmarks for cache method connect."""
+
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from cache.noop_cache import NoopCache
+
+
+def test_noop_cache(noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture) -> None:
+    """Benchmark for the connect method."""
+    benchmark(noop_cache_fixture.connect)

tests/benchmarks/test_cache_delete.py

@@ -0,0 +1,44 @@
+"""Benchmarks for deleting data from cache."""
+
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from cache.noop_cache import NoopCache
+
+from .cache_data import (
+    CONVERSATION_ID_1,
+    USER_ID,
+    USER_PROVIDED_USER_ID,
+    cache_entry_1,
+)
+
+
+def test_noop_cache_existing_conversation(
+    noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture
+) -> None:
+    """Benchmark for deleting an existing conversation."""
+    noop_cache_fixture.insert_or_append(USER_ID, CONVERSATION_ID_1, cache_entry_1)
+    benchmark(noop_cache_fixture.delete, USER_ID, CONVERSATION_ID_1)
+
+
+def test_noop_cache_nonexistent_conversation(
+    noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture
+) -> None:
+    """Benchmark for deleting a conversation that doesn't exist."""
+    benchmark(noop_cache_fixture.delete, USER_ID, CONVERSATION_ID_1)
+
+
+def test_noop_cache_skip_user_id_check(
+    noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture
+) -> None:
+    """Benchmark for deleting an existing conversation."""
+    skip_user_id_check = True
+    noop_cache_fixture.insert_or_append(
+        USER_PROVIDED_USER_ID, CONVERSATION_ID_1, cache_entry_1, skip_user_id_check
+    )
+
+    benchmark(
+        noop_cache_fixture.delete,
+        USER_PROVIDED_USER_ID,
+        CONVERSATION_ID_1,
+        skip_user_id_check,
+    )

tests/benchmarks/test_cache_get.py

@@ -0,0 +1,47 @@
+"""Benchmarks for retrieving data from cache."""
+
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from cache.noop_cache import NoopCache
+
+from .cache_data import (
+    CONVERSATION_ID_1,
+    CONVERSATION_ID_2,
+    USER_ID,
+    cache_entry_1,
+    cache_entry_2,
+)
+
+
+def test_noop_cache_empty_cache(
+    noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture
+) -> None:
+    """Benchmark retrieving existing items."""
+    # this UUID is different from DEFAULT_USER_UID
+    benchmark(
+        noop_cache_fixture.get,
+        "ffffffff-ffff-ffff-ffff-ffffffffffff",
+        CONVERSATION_ID_1,
+    )
+
+
+def test_noop_cache_existing_user(
+    noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture
+) -> None:
+    """Benchmark retrieving existing items."""
+    # this UUID is different from DEFAULT_USER_UID
+    noop_cache_fixture.insert_or_append(
+        USER_ID,
+        CONVERSATION_ID_1,
+        cache_entry_1,
+    )
+    noop_cache_fixture.insert_or_append(
+        USER_ID,
+        CONVERSATION_ID_2,
+        cache_entry_2,
+    )
+    benchmark(
+        noop_cache_fixture.get,
+        USER_ID,
+        CONVERSATION_ID_1,
+    )

tests/benchmarks/test_cache_insert_or_append.py

@@ -0,0 +1,21 @@
+"""Benchmarks for cache method insert__or_append."""
+
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from cache.noop_cache import NoopCache
+
+from .cache_data import (
+    CONVERSATION_ID_1,
+    USER_ID,
+    cache_entry_1,
+)
+
+
+def test_noop_cache(noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture) -> None:
+    """Benchmark for the insert_or_append method."""
+    benchmark(
+        noop_cache_fixture.insert_or_append,
+        USER_ID,
+        CONVERSATION_ID_1,
+        cache_entry_1,
+    )

tests/benchmarks/test_cache_insert_or_append_existing_key.py

@@ -0,0 +1,28 @@
+"""Benchmarks for cache method insert__or_append."""
+
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from cache.noop_cache import NoopCache
+
+from .cache_data import (
+    CONVERSATION_ID_1,
+    CONVERSATION_ID_2,
+    USER_ID,
+    cache_entry_1,
+    cache_entry_2,
+)
+
+
+def test_noop_cache(noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture) -> None:
+    """Benchmark for insert_or_append method for existing item."""
+    noop_cache_fixture.insert_or_append(
+        USER_ID,
+        CONVERSATION_ID_1,
+        cache_entry_1,
+    )
+    benchmark(
+        noop_cache_fixture.insert_or_append,
+        USER_ID,
+        CONVERSATION_ID_2,
+        cache_entry_2,
+    )

tests/benchmarks/test_cache_insert_or_append_skip_user_id_check.py

@@ -0,0 +1,31 @@
+"""Benchmarks for cache method insert__or_append."""
+
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from cache.noop_cache import NoopCache
+
+from .cache_data import (
+    CONVERSATION_ID_1,
+    USER_PROVIDED_USER_ID,
+    cache_entry_1,
+)
+
+
+def test_noop_cache(noop_cache_fixture: NoopCache, benchmark: BenchmarkFixture) -> None:
+    """Benchmark for the insert_or_append method.
+
+    Verify that insert_or_append accepts a non-UUID user identifier when
+    skip_user_id_check is True.
+
+    This test calls insert_or_append with a user-provided (non-UUID) user id, a
+    conversation id, and a cache entry while passing skip_user_id_check=True;
+    the operation is expected to complete without raising an exception.
+    """
+    skip_user_id_check = True
+    benchmark(
+        noop_cache_fixture.insert_or_append,
+        USER_PROVIDED_USER_ID,
+        CONVERSATION_ID_1,
+        cache_entry_1,
+        skip_user_id_check,
+    )