From 6bcadc7c9f96b78b1edda3ce2148f19cd67d5b4e Mon Sep 17 00:00:00 2001 From: Charlie Dowler Date: Thu, 13 Aug 2026 23:48:55 +0100 Subject: [PATCH] fix: drop invalid `merged` activity type from close-preview template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `merged` is not a valid `pull_request` activity type — GitHub delivers a merge as `closed` with `github.event.pull_request.merged == true`. The template is copied verbatim into customer repositories, where it is the teardown for Lightdash preview projects. The job body is unconditional (`lightdash stop-preview` on any close), so `types: [closed]` is behaviour-identical and complete: previews are torn down whether the PR was merged or abandoned, which is the intent. Also removes the corresponding entry from the actionlint baseline, which was suppressing this as tracked debt. actionlint is now clean on the templates without it. Linear: PROD-10126 --- .github/actionlint.yaml | 4 ---- close-preview.yml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml index 2185ca4..f00cdf2 100644 --- a/.github/actionlint.yaml +++ b/.github/actionlint.yaml @@ -3,7 +3,3 @@ paths: "{compile,deploy,start-preview,close-preview,refresh,lightdash-validate}.yml": ignore: - "shellcheck reported issue" - # Genuine validity error tracked in PROD-10126; remove when that ticket is fixed. - close-preview.yml: - ignore: - - "invalid activity type \"merged\"" diff --git a/close-preview.yml b/close-preview.yml index 99fca4f..a5b1909 100644 --- a/close-preview.yml +++ b/close-preview.yml @@ -3,7 +3,7 @@ name: close-preview on: pull_request: - types: [closed, merged] + types: [closed] jobs: preview: