Skip to content

Final cleanup after constants migration #187

@rtibbles

Description

@rtibbles

This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Final cleanup tasks after all 5 module migrations are complete. This issue removes the legacy resources/ directory and updates configuration files.

Prerequisites

Blocked by: #182, #183, #184, #185, #186

All 5 module migrations must be completed before this cleanup can proceed.

Tasks

  1. Remove package_data from setup.py

    • Remove the line: package_data={"le_utils": ["resources/*.json"]}
    • The resources directory will no longer exist, so this must be removed
  2. Delete le_utils/resources/ directory

    • Verify all JSON files have been deleted by individual migration issues
    • Remove the empty resources/ directory itself
  3. Update README.md

    • Remove warnings about keeping Python/JSON in sync
    • Update documentation to describe spec + generation workflow
    • Remove references to manual constants maintenance
  4. Update CHANGELOG.md

    • Add entry for the migration with version number
    • List all migrated modules
    • Note JavaScript exports now available for all constants
  5. Verify entire test suite passes

    • Run pytest tests/ -v
    • Ensure no broken imports or references to old JSON files

How to Verify

# Ensure resources directory doesn't exist
ls le_utils/resources/  # should error: No such file or directory

# Verify tests pass
pytest tests/ -v

# Verify build works
make build

# Verify package can be installed
python setup.py sdist
pip install dist/le-utils-*.tar.gz

Acceptance Criteria

  • package_data removed from setup.py
  • le_utils/resources/ directory deleted
  • README.md updated to remove sync warnings
  • README.md updated to document spec + generation workflow
  • CHANGELOG.md updated with migration notes
  • All tests pass: pytest tests/ -v
  • make build succeeds
  • Package builds and installs successfully

Disclosure

🤖 This issue was written by Claude Code, under supervision, review and final edits by @rtibbles 🤖

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No fields configured for Task.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions