s/linux64FileExtension/linux64RemoveExecutableExtension/

and the rest that this entails.

This PR should probably be squashed before merging,
with attention paid to the commit message.

Author: kitlith

action.yml

@@ -279,11 +279,11 @@ inputs:
     description:
       '[Orchestrator] Specifies the repo for the unity builder. Useful if you forked the repo for testing, features, or
       fixes.'
-  linux64FileExtension:
-    default: ''
+  linux64RemoveExecutableExtension:
+    default: 'true'
     required: false
     description:
-      'Specify the file extension of the executable when building for StandaloneLinux64. For example, ".x86_64"'
+      'When building for StandaloneLinux64, remove the default file extension of `.x86_64`. (This matches the behavior of older versions of this action)'
 
 outputs:
   volume:

dist/index.js

@@ -104,21 +104,21 @@ describe('BuildParameters', () => {
     });
 
     test.each`
-      targetPlatform                        | expectedExtension | androidExportType         | linux64FileExtension
-      ${Platform.types.Android}             | ${'.apk'}         | ${'androidPackage'}       | ${'n/a'}
-      ${Platform.types.Android}             | ${'.aab'}         | ${'androidAppBundle'}     | ${'n/a'}
-      ${Platform.types.Android}             | ${''}             | ${'androidStudioProject'} | ${'n/a'}
-      ${Platform.types.StandaloneWindows}   | ${'.exe'}         | ${'n/a'}                  | ${'n/a'}
-      ${Platform.types.StandaloneWindows64} | ${'.exe'}         | ${'n/a'}                  | ${'n/a'}
-      ${Platform.types.StandaloneLinux64}   | ${''}             | ${'n/a'}                  | ${''}
-      ${Platform.types.StandaloneLinux64}   | ${'.x86_64'}      | ${'n/a'}                  | ${'.x86_64'}
+      targetPlatform                        | expectedExtension | androidExportType         | linux64RemoveExecutableExtension
+      ${Platform.types.Android}             | ${'.apk'}         | ${'androidPackage'}       | ${false}
+      ${Platform.types.Android}             | ${'.aab'}         | ${'androidAppBundle'}     | ${true}
+      ${Platform.types.Android}             | ${''}             | ${'androidStudioProject'} | ${false}
+      ${Platform.types.StandaloneWindows}   | ${'.exe'}         | ${'n/a'}                  | ${true}
+      ${Platform.types.StandaloneWindows64} | ${'.exe'}         | ${'n/a'}                  | ${false}
+      ${Platform.types.StandaloneLinux64}   | ${''}             | ${'n/a'}                  | ${true}
+      ${Platform.types.StandaloneLinux64}   | ${'.x86_64'}      | ${'n/a'}                  | ${false}
     `(
-      'appends $expectedExtension for $targetPlatform with androidExportType $androidExportType and linux64FileExtension $linux64FileExtension',
-      async ({ targetPlatform, expectedExtension, androidExportType, linux64FileExtension }) => {
+      'appends $expectedExtension for $targetPlatform with androidExportType $androidExportType and linux64RemoveExecutableExtension $linux64RemoveExecutableExtension',
+      async ({ targetPlatform, expectedExtension, androidExportType, linux64RemoveExecutableExtension }) => {
         jest.spyOn(Input, 'targetPlatform', 'get').mockReturnValue(targetPlatform);
         jest.spyOn(Input, 'buildName', 'get').mockReturnValue(targetPlatform);
         jest.spyOn(Input, 'androidExportType', 'get').mockReturnValue(androidExportType);
-        jest.spyOn(Input, 'linux64FileExtension', 'get').mockReturnValue(linux64FileExtension);
+        jest.spyOn(Input, 'linux64RemoveExecutableExtension', 'get').mockReturnValue(linux64RemoveExecutableExtension);
         await expect(BuildParameters.create()).resolves.toEqual(
           expect.objectContaining({ buildFile: `${targetPlatform}${expectedExtension}` }),
         );

dist/index.js.map

@@ -116,7 +116,7 @@ class BuildParameters {
       Input.buildName,
       Input.targetPlatform,
       Input.androidExportType,
-      Input.linux64FileExtension,
+      Input.linux64RemoveExecutableExtension,
     );
     const editorVersion = UnityVersioning.determineUnityVersion(Input.projectPath, Input.unityVersion);
     const buildVersion = await Versioning.determineBuildVersion(Input.versioningStrategy, Input.specifiedVersion);
@@ -254,7 +254,7 @@ class BuildParameters {
     filename: string,
     platform: string,
     androidExportType: string,
-    linux64FileExtension: string,
+    linux64RemoveExecutableExtension: boolean,
   ): string {
     if (Platform.isWindows(platform)) {
       return `${filename}.exe`;
@@ -275,8 +275,8 @@ class BuildParameters {
       }
     }
 
-    if (platform === Platform.types.StandaloneLinux64) {
-      return `${filename}${linux64FileExtension}`;
+    if (platform === Platform.types.StandaloneLinux64 && !linux64RemoveExecutableExtension) {
+      return `${filename}.x86_64`;
     }
 
     return filename;

src/model/build-parameters.test.ts

@@ -335,15 +335,20 @@ describe('Input', () => {
     });
   });
 
-  describe('linux64FileExtension', () => {
+  describe('linux64RemoveExecutableExtension', () => {
     it('returns the default value', () => {
-      expect(Input.linux64FileExtension).toStrictEqual('');
+      expect(Input.linux64RemoveExecutableExtension).toStrictEqual(true);
     });
 
-    it('takes input from the users workflow', () => {
-      const mockValue = '.x86_64';
-      const spy = jest.spyOn(core, 'getInput').mockReturnValue(mockValue);
-      expect(Input.linux64FileExtension).toStrictEqual(mockValue);
+    it('returns true when string true is passed', () => {
+      const spy = jest.spyOn(core, 'getInput').mockReturnValue('true');
+      expect(Input.linux64RemoveExecutableExtension).toStrictEqual(true);
+      expect(spy).toHaveBeenCalledTimes(1);
+    });
+
+    it('returns false when string false is passed', () => {
+      const spy = jest.spyOn(core, 'getInput').mockReturnValue('false');
+      expect(Input.linux64RemoveExecutableExtension).toStrictEqual(false);
       expect(spy).toHaveBeenCalledTimes(1);
     });
   });

src/model/build-parameters.ts

@@ -282,8 +282,10 @@ class Input {
     return Input.getInput('skipActivation')?.toLowerCase() ?? 'false';
   }
 
-  static get linux64FileExtension(): string {
-    return Input.getInput('linux64FileExtension') ?? '';
+  static get linux64RemoveExecutableExtension(): boolean {
+    const input = Input.getInput('linux64RemoveExecutableExtension') ?? 'true';
+
+    return input === 'true';
   }
 
   public static ToEnvVarFormat(input: string) {