Prevent submission of empty HTML comments (e.g. <p></p>)

Agent-Logs-Url: https://github.com/kirschbaum-development/commentions/sessions/33ccb0f6-9921-40e0-a10b-729ba43a5a94

Co-authored-by: luisdalmolin <403446+luisdalmolin@users.noreply.github.com>

Author: Copilot

src/Livewire/Comment.php

@@ -24,9 +24,20 @@ class Comment extends Component
 
     public ?string $tipTapCssClasses = null;
 
-    protected $rules = [
-        'commentBody' => 'required|string',
-    ];
+    protected function rules(): array
+    {
+        return [
+            'commentBody' => [
+                'required',
+                'string',
+                function ($attribute, $value, $fail) {
+                    if (trim(strip_tags($value)) === '') {
+                        $fail(__('validation.required', ['attribute' => 'comment body']));
+                    }
+                },
+            ],
+        ];
+    }
 
     #[On('comment:reaction:toggled')]
     public function handleReactionToggledEvent(string $reaction, int $commentId): void
@@ -93,6 +104,8 @@ public function updateComment()
             return;
         }
 
+        $this->validate();
+
         $this->comment->update([
             'body' => $this->commentBody,
         ]);

src/Livewire/Comments.php

@@ -26,9 +26,20 @@ class Comments extends Component
 
     public ?string $tipTapCssClasses = null;
 
-    protected $rules = [
-        'commentBody' => 'required|string',
-    ];
+    protected function rules(): array
+    {
+        return [
+            'commentBody' => [
+                'required',
+                'string',
+                function ($attribute, $value, $fail) {
+                    if (trim(strip_tags($value)) === '') {
+                        $fail(__('validation.required', ['attribute' => 'comment body']));
+                    }
+                },
+            ],
+        ];
+    }
 
     #[Renderless]
     public function save()

tests/Livewire/CommentTest.php

@@ -97,6 +97,28 @@
     ]);
 });
 
+test('updating comment is rejected when body contains only empty html tags', function () {
+    $user = User::factory()->create();
+    actingAs($user);
+
+    $post = Post::factory()->create();
+    $comment = CommentModel::factory()->author($user)->commentable($post)->create([
+        'body' => 'Test comment body',
+    ]);
+
+    livewire(CommentComponent::class, [
+        'comment' => $comment,
+    ])
+        ->set('commentBody', '<p></p>')
+        ->call('updateComment')
+        ->assertHasErrors(['commentBody']);
+
+    test()->assertDatabaseHas('comments', [
+        'id' => $comment->id,
+        'body' => 'Test comment body',
+    ]);
+});
+
 test('other users cannot update a comment by default', function () {
     $user = User::factory()->create();
     actingAs($user);

tests/Livewire/CommentsTest.php

@@ -63,6 +63,26 @@
     ]);
 });
 
+test('comment creation is rejected when body contains only empty html tags', function () {
+    /** @var User $user */
+    $user = User::factory()->create();
+    actingAs($user);
+
+    $post = Post::factory()->create();
+
+    livewire(Comments::class, [
+        'record' => $post,
+    ])
+        ->set('commentBody', '<p></p>')
+        ->call('save')
+        ->assertHasErrors(['commentBody']);
+
+    $this->assertDatabaseMissing('comments', [
+        'commentable_id' => $post->id,
+        'commentable_type' => Post::class,
+    ]);
+});
+
 test('guests cannot create comments', function () {
     Event::fake();