Repository navigation
Commit 6c4ad17
committed
test(xrp): skip the THORChain memo test, without weakening its assertion
XRP memo is not a supported feature yet, and the assertion is correct -- it
describes what the product needs, not what the code does. So it is skipped with
a specific reason rather than rewritten to accept the loss.
The memo cannot traverse hdwallet -> RippleSignTx. The KeepKey protobuf has no
memo field (RippleSignTx carries fields 1-6; RipplePayment carries
amount/destination/destination_tag), and hdwallet's rippleSignTx never reads
tx.value.memo -- it references msg.tx.value exactly twice, .fee and .msg. The
firmware therefore never receives a memo and cannot serialize one. No firmware
change makes this pass.
Making it green by asserting the memo is ABSENT would encode the bug as the
contract, so the body is untouched and the skip reason says so explicitly.
The host-side gap is tracked as keepkey/keepkey-vault#422: buildXrpTx routes
THORChain memos to tx.value.memo, index.ts signs via rippleSignTx, and the
memo is discarded -- producing a valid XRP payment to the THORChain inbound
vault with no routing memo. XRP swaps do not currently work, so this is armed
rather than actively losing funds, and the recommended host fix is to fail
closed in buildXrpTx rather than sign a memo-less payment.
Re-enable only when the signed serialization preserves the memo.1 parent c75fbd5 commit 6c4ad17
1 file changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
103 | 117 | | |
104 | 118 | | |
105 | 119 | | |
| |||
0 commit comments