Icon names changed in KDE 5.17.3, missing icons

[velnias75]

After an update to KDE 5.17.3 most media icons have been missing due to a rename of the icon names:

in icons/media

• media-playback-start has changed to ww-hh-media-playback-start
• media-playback-pause has changed to ww-hh-media-playback-pause
• media-playback-stop has changed to ww-hh-media-playback-stop
• media-skip-backward has changed to ww-hh-media-skip-backward
• media-skip-forward has changed to ww-hh-media-skip-forward

where ww-hh- can be one of the following:

1. 16-16-
2. 22-22-
3. 32-32-

Would it be poosible to use the renamed icons if available and otherwise the ones without the ww-hh--prefix (for downward compatibility)?

(With inkscape you can inspect /usr/share/plasma/desktoptheme/default/icons/media.svgz.)

[tillschaefer]

I have also a missing play/pause button. Do you have any other icons than play/pause missing? Can you elaborate, if the analysis below applies to you or if we are talking about different bugs? In the second case, I will open another bug report.

To my knowledge you do not specify the size of the icons in fixed pixels in plasmoids, but let the theme handle that for you. I can also hardly imagine the developers to break such basic theme icons. Furthermore, I cannot see any files with that naming scheme in Gentoo (plasma 5.17.3 and frameworks 5.64).
Thus, have you tried another icon theme? Are you sure this rename in the cause of the icons missing?

I in my case I have dug into the code and tried to understand what makes play/pause different from the other icons. I also noticed that play/pause is shown whenever I activate the stop button. It seems that the play/pause button is scaled up in the case the stop button is not shown. removing that scaling factor fixed the icons for me.

diff --git a/plasmoid/contents/ui/PlaybackWidget.qml b/plasmoid/contents/ui/PlaybackWidget.qml
index 434e105..a4609ae 100644
--- a/plasmoid/contents/ui/PlaybackWidget.qml
+++ b/plasmoid/contents/ui/PlaybackWidget.qml
@@ -71,7 +71,7 @@ PlaybackItem {
             id: toolButton
             iconSource: icon
             visible: !(index === 2) | showStop
-            property int size: !showStop && index === 1 ? buttonSize.width * 1.4 : buttonSize.width
+            property int size: !showStop && index === 1 ? buttonSize.width * 1 : buttonSize.width
             enabled: mpris2.sourceActive
             Layout.minimumWidth: size
             Layout.minimumHeight: size

[velnias75]

There have been really a change to media.svg: [icons/media.svg] Add 16 & 32px icons, update style
These changed ids cause playbar2 not to show the correct icons.

I've forked playbar2 and applied the new ids and all is working so far: https://github.com/velnias75/playbar2

If I get it managed to keep it backward compatible, I'll create a pull request for this repository

[a17r]

Some clarifications: KDE 5.17.3, you certainly mean Plasma 5.17.3, is not involved in this.

/usr/share/plasma/desktoptheme/default/icons/media.svgz is owned by plasma-framework as part of the KDE Frameworks release, not Plasma. Renaming of the mentioned icons happened in upstream commit 15ed55b4, that would mean you have to test for KF5 release >=5.64.0.

Applications however should make use of breeze-icons, it is odd that playbar2 would depend on plasma-framework for that.