Kafka's missing from the validLogging map #927
feynmanpan
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Found a small bug — confirmed present in v0.5.4, still on develop too:
LoggingKafka is defined in pkg/config/types.go, and YAMLConfigurationLogger even has a Kafka *KafkaLogger field
But it's missing from the validLogging map in pkg/config/validation.go
Result: setting logger.type: kafka causes osctrl-tls to fail startup with invalid logging method: kafka, even though the Kafka logger is otherwise implemented
Verified directly against the v0.5.4 tag's source — same gap there
Fix is a one-liner — just add LoggingKafka: true to validLogging
All reactions