[Xray] chart creates RabbitMQ load-definition Secret even when loadDefinition.enabled=false

[gianluca-fiasco]

Scope

• observed in stable/xray
• Template logic only
• No behavioral debate

Problem

• valus.rabbitmq.loadDefinition.enabled is ignored
• Secret can be rendered when load definitions are disabled

Suggestion

change this line

charts/stable/xray/templates/rabbitmq-load-definition-secret.yaml

Line 1 in 1ac9a55

{{- if and .Values.rabbitmq.enabled (eq .Values.rabbitmq.loadDefinition.existingSecret "{{ .Release.Name }}-load-definition") (not .Values.rabbitmq.external.secrets)}}

with

{{- if and
  .Values.rabbitmq.enabled
  .Values.rabbitmq.loadDefinition.enabled
  (eq .Values.rabbitmq.loadDefinition.existingSecret (printf "%s-load-definition" .Release.Name))
  (not .Values.rabbitmq.external.secrets)
}}