fix(projects): use normalized name lookup for project URLs (#1247)

Implement PyPI-style PEP 426 name normalization for project lookups:

- Use func.normalize_pep426_name() to query projects case-insensitively
- Redirect non-canonical URLs to canonical names with 301 redirects
- Update template to use project.name instead of normalized_name

This fixes issues where projects with capitalized names (e.g., Watson)
could not be accessed via lowercase URLs (/projects/watson).

Now:
- /projects/watson -> 301 redirect to /projects/Watson
- /projects/Watson -> 200 OK (canonical URL)
- /projects/some_project -> 301 redirect to /projects/some-project

Author: jezdez

jazzband/projects/views.py

@@ -95,7 +95,16 @@ def index():
 
 class ProjectMixin:
     def project_query(self, name):
-        return Project.query.filter(Project.is_active.is_(True), Project.name == name)
+        """
+        Query for a project by normalized name (case-insensitive).
+
+        Uses the same PEP 426 normalization as PyPI: lowercase and
+        collapse runs of dots, underscores, and hyphens to a single hyphen.
+        """
+        return Project.query.filter(
+            Project.is_active.is_(True),
+            Project.normalized_name == func.normalize_pep426_name(name),
+        )
 
     def project_name(self, *args, **kwargs):
         name = kwargs.get("name")
@@ -109,6 +118,15 @@ def redirect_to_project(self):
     def dispatch_request(self, *args, **kwargs):
         name = self.project_name(*args, **kwargs)
         self.project = self.project_query(name).first_or_404()
+
+        # Redirect to canonical URL if the name doesn't match exactly
+        # (e.g., /projects/watson -> /projects/Watson)
+        if name != self.project.name:
+            return redirect(
+                url_for(request.endpoint, name=self.project.name),
+                code=301,
+            )
+
         return super().dispatch_request(*args, **kwargs)
 
 

jazzband/templates/projects/index.html

@@ -49,7 +49,7 @@ <h2>Projects</h2>
     <tbody>
       {% for project in projects %}
       <tr>
-        <td><a href="{{ url_for('projects.detail', name=project.normalized_name) }}">{{ project.name }}</a></td>
+        <td><a href="{{ url_for('projects.detail', name=project.name) }}">{{ project.name }}</a></td>
         <td class="numbers"></td>
         <td class="numbers">{{ project.membership_count or 0 }}</td>
         <td class="numbers">{{ project.uploads_count or 0 }}</td>

tests/test_project_name_normalization.py

@@ -0,0 +1,111 @@
+"""Function-based tests for project name normalization and canonical URL redirects.
+
+Converted from class-based tests to follow `AGENTS.md` testing conventions.
+"""
+
+import pytest
+from werkzeug.exceptions import NotFound
+
+from jazzband.projects.views import ProjectMixin
+
+
+def test_project_query_uses_normalized_name(app, mocker):
+    """ProjectMixin.project_query should use normalized name for lookup."""
+    with app.app_context():
+        mock_query = mocker.MagicMock()
+        mock_query.filter.return_value = mock_query
+
+        mocker.patch("jazzband.projects.views.Project.query", mock_query)
+
+        mixin = ProjectMixin()
+        mixin.project_query("Watson")
+
+        assert mock_query.filter.called
+
+
+def test_project_name_returns_name_from_kwargs(app):
+    """ProjectMixin.project_name should return name from kwargs."""
+    with app.app_context():
+        mixin = ProjectMixin()
+        assert mixin.project_name(name="test-project") == "test-project"
+
+
+def test_project_name_aborts_if_no_name(app):
+    """ProjectMixin.project_name should abort with NotFound if no name provided."""
+    with app.app_context():
+        mixin = ProjectMixin()
+        with pytest.raises(NotFound):
+            mixin.project_name()
+
+
+def test_lowercase_url_finds_capitalized_project(app, mocker):
+    """/projects/watson should redirect to canonical /projects/Watson."""
+    with app.test_client() as client:
+        mock_project = mocker.MagicMock()
+        mock_project.name = "Watson"
+        mock_project.is_active = True
+
+        mock_query = mocker.MagicMock()
+        mock_query.filter.return_value.first_or_404.return_value = mock_project
+
+        mocker.patch("jazzband.projects.views.Project.query", mock_query)
+
+        response = client.get("/projects/watson", follow_redirects=False)
+
+        assert response.status_code == 301
+        assert "/projects/Watson" in response.headers["Location"]
+
+
+def test_canonical_url_does_not_redirect(app, mocker):
+    """Canonical URL should not redirect."""
+    with app.test_client() as client:
+        mock_project = mocker.MagicMock()
+        mock_project.name = "Watson"
+        mock_project.is_active = True
+        mock_project.uploads = mocker.MagicMock()
+        mock_project.uploads.order_by.return_value = []
+
+        mock_query = mocker.MagicMock()
+        mock_query.filter.return_value.first_or_404.return_value = mock_project
+
+        mocker.patch("jazzband.projects.views.Project.query", mock_query)
+
+        response = client.get("/projects/Watson", follow_redirects=False)
+
+        assert response.status_code != 301
+
+
+def test_uppercase_url_redirects_to_canonical(app, mocker):
+    """/projects/WATSON should redirect to canonical /projects/Watson."""
+    with app.test_client() as client:
+        mock_project = mocker.MagicMock()
+        mock_project.name = "Watson"
+        mock_project.is_active = True
+
+        mock_query = mocker.MagicMock()
+        mock_query.filter.return_value.first_or_404.return_value = mock_project
+
+        mocker.patch("jazzband.projects.views.Project.query", mock_query)
+
+        response = client.get("/projects/WATSON", follow_redirects=False)
+
+        assert response.status_code == 301
+        assert "/projects/Watson" in response.headers["Location"]
+
+
+def test_hyphen_underscore_normalization(app, mocker):
+    """/projects/some_project should redirect to canonical /projects/some-project."""
+    with app.test_client() as client:
+        mock_project = mocker.MagicMock()
+        mock_project.name = "some-project"
+        mock_project.is_active = True
+
+        mock_query = mocker.MagicMock()
+        mock_query.filter.return_value.first_or_404.return_value = mock_project
+
+        mocker.patch("jazzband.projects.views.Project.query", mock_query)
+
+        response = client.get("/projects/some_project", follow_redirects=False)
+
+        assert response.status_code == 301
+        assert "/projects/some-project" in response.headers["Location"]