From 064dddb1c413b2f45307ff4b7b67700256d88609 Mon Sep 17 00:00:00 2001 From: Hiroki Itoh Date: Sun, 12 Apr 2026 19:04:59 +0900 Subject: [PATCH 1/3] feat: Build desktop app for x64 and arm64 --- .github/workflows/build.yml | 28 +++++++++++++++++++---- packages/app/electron-builder-config.json | 3 +++ 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6ea58cc..1b5ba1f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -46,10 +46,30 @@ jobs: # desktop: needs: check - runs-on: ${{ matrix.os }} + runs-on: ${{ matrix.runs_on }} strategy: matrix: - os: [macos-latest, ubuntu-latest, windows-latest] + include: + - os: macos + runs_on: macos-latest + artifact_suffix: macos-universal + electron_builder_args: -c electron-builder-config.json --universal + - os: linux + runs_on: ubuntu-latest + artifact_suffix: linux-x64 + electron_builder_args: -c electron-builder-config.json --x64 + - os: linux + runs_on: ubuntu-24.04-arm + artifact_suffix: linux-arm64 + electron_builder_args: -c electron-builder-config.json --arm64 + - os: windows + runs_on: windows-latest + artifact_suffix: windows-x64 + electron_builder_args: -c electron-builder-config.json --x64 + - os: windows + runs_on: windows-11-arm + artifact_suffix: windows-arm64 + electron_builder_args: -c electron-builder-config.json --arm64 steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 @@ -79,12 +99,12 @@ jobs: release: ${{ startsWith(github.ref, 'refs/tags/v') }} skip_build: true package_root: packages/app/ - args: -c electron-builder-config.json + args: ${{ matrix.electron_builder_args }} - name: Archive artifacts uses: actions/upload-artifact@v4 with: - name: live-comment-for-${{ matrix.os }}-${{ github.run_number }} + name: live-comment-for-${{ matrix.artifact_suffix }}-${{ github.run_number }} path: packages/app/dist/live-comment* # # Build server side apps diff --git a/packages/app/electron-builder-config.json b/packages/app/electron-builder-config.json index 2fbf087..71194df 100644 --- a/packages/app/electron-builder-config.json +++ b/packages/app/electron-builder-config.json @@ -16,6 +16,7 @@ "releaseType": "draft" }, "win": { + "artifactName": "${productName}-${version}-${arch}.${ext}", "target": [{ "target": "nsis", "arch": ["x64"] @@ -24,6 +25,7 @@ "icon": "resources/kujira.png" }, "mac": { + "artifactName": "${productName}-${version}-${arch}.${ext}", "target": [{ "target": "dmg", "arch": ["x64"] @@ -33,6 +35,7 @@ }, "linux": { "executableName": "live-comment", + "artifactName": "${productName}-${version}-${arch}.${ext}", "target": [{ "target": "deb", "arch": ["x64"] From aeb140ae41fcd4dc515f2369f3e3a6728d00d831 Mon Sep 17 00:00:00 2001 From: Hiroki Itoh Date: Sun, 12 Apr 2026 19:25:27 +0900 Subject: [PATCH 2/3] fix: Remove linux arm64 --- .github/workflows/build-extension.yml | 2 +- .github/workflows/build.yml | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-extension.yml b/.github/workflows/build-extension.yml index 1325b91..1becb9c 100644 --- a/.github/workflows/build-extension.yml +++ b/.github/workflows/build-extension.yml @@ -67,7 +67,7 @@ jobs: asset_content_type: application/zip - name: Archive artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v6 with: name: browser-extension-${{ inputs.host }}-${{ github.run_number }} path: build/apps/browser-extension/ diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1b5ba1f..8c4b9a3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -58,10 +58,6 @@ jobs: runs_on: ubuntu-latest artifact_suffix: linux-x64 electron_builder_args: -c electron-builder-config.json --x64 - - os: linux - runs_on: ubuntu-24.04-arm - artifact_suffix: linux-arm64 - electron_builder_args: -c electron-builder-config.json --arm64 - os: windows runs_on: windows-latest artifact_suffix: windows-x64 @@ -102,7 +98,7 @@ jobs: args: ${{ matrix.electron_builder_args }} - name: Archive artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v6 with: name: live-comment-for-${{ matrix.artifact_suffix }}-${{ github.run_number }} path: packages/app/dist/live-comment* @@ -168,7 +164,7 @@ jobs: asset_content_type: application/zip - name: Archive artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v6 with: name: server-apps-${{ github.run_number }} path: build/apps/ From dc538c6e4d3779dacb4993750a1ecb7c18a10416 Mon Sep 17 00:00:00 2001 From: Hiroki Itoh Date: Sun, 12 Apr 2026 21:54:51 +0900 Subject: [PATCH 3/3] fix: Remove windows arm build --- .github/workflows/build.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8c4b9a3..e557f4a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -62,10 +62,6 @@ jobs: runs_on: windows-latest artifact_suffix: windows-x64 electron_builder_args: -c electron-builder-config.json --x64 - - os: windows - runs_on: windows-11-arm - artifact_suffix: windows-arm64 - electron_builder_args: -c electron-builder-config.json --arm64 steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4