GM secret deleted on shared notes

[prinzwalium]

What happened?

First of all: Great work! I would really love to get Grimoire going as collective campaign knowledge base with my players.

GM secrets get overwritten by players editing their own public notes.

Additionally I noted other things:

• Players can only create public notes. I think players should be able to create private notes, notes shared with specific players and GM, notes shared with only the GM

• Public notes created by the GM are not editable by the players

I imagine that making the GM secrets outlive edits by a player might be difficult. Maybe it's possible that each note is accompanied by another note field that is only available to the GM?

Steps to reproduce

1. Player creates a public note.
2. GM edits that with a GM secret.
3. Player editing again and saving.
4. GM secret is gone.

What did you expect to happen?

GM secret should still be there

How are you running Grimoire?

Docker Compose (DockerHub image)

Grimoire version or commit

No response

Browser

Chrome / Chromium

Relevant logs or error messages

Anything else?

The logs didn't show anything specific to this.

[hunter-read]

The core bug in this issue, GM secrets being erased when a player edits a shared note, is being fixed here. The two additional requests from the report have been split into their own follow-up issues:

• Players can only create group-visible wiki notes, not private / member-shared / GM-only ones #232 — Players should be able to create private / member-shared / GM-only notes (not just group-visible ones)
• Players cannot edit GM-authored public (group) wiki notes #233 — Players should be able to edit GM-authored public (group) notes

This issue stays scoped to the secret-preservation fix.