diff --git a/module/conviction.amlg b/module/conviction.amlg index c8e5c25eb..e15202eed 100644 --- a/module/conviction.amlg +++ b/module/conviction.amlg @@ -818,7 +818,11 @@ ) (declare (assoc - feature_weights (get hyperparam_map "featureWeights") + feature_weights + (if (size (get hyperparam_map "featureMdaMap")) + (get hyperparam_map "featureMdaMap") + (get hyperparam_map "featureWeights") + ) feature_deviations (get hyperparam_map "featureDeviations") )) diff --git a/module/details.amlg b/module/details.amlg index b741f1975..d1de30b23 100644 --- a/module/details.amlg +++ b/module/details.amlg @@ -151,8 +151,7 @@ feature_deviations (get hyperparam_map "featureDeviations") feature_weights - ;only use featureMdaMap weights if there are action_features provided - (if (and (size (get hyperparam_map "featureMdaMap")) (size action_features)) + (if (size (get hyperparam_map "featureMdaMap")) (get hyperparam_map "featureMdaMap") (get hyperparam_map "featureWeights") ) diff --git a/unit_tests/ut_h_rebalance_features.amlg b/unit_tests/ut_h_rebalance_features.amlg index 6855f9028..ab9938307 100644 --- a/unit_tests/ut_h_rebalance_features.amlg +++ b/unit_tests/ut_h_rebalance_features.amlg @@ -353,7 +353,7 @@ ;geomean 0 ;weights of cases (order isn't relevant since distance/surprisal to each is same) - [1 2] + (normalize [1 2]) ) ))