docs: fix edit distance string parameter name#573
Closed
domg123-hermes wants to merge 1 commit into
Closed
Conversation
Contributor
|
PR is now redundant due to the more comprehensive fix in #574 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commonality/edit_distanceopcode descriptions to name the actual string-mode parameter key:string_edit_distance.OpcodeDetailssource text.Context
The parameter list and examples already use
{string_edit_distance .true}, and the runtime lookup is registered asENBISI_string_edit_distance/"string_edit_distance". The prose descriptions still referred to"use_string_edit_distance", which is not a registered key and is ignored by the current runtime.Verification
rg -n 'use_string_edit_distance'→ no matches(commonality "hello" "hello" {string_edit_distance .true})→5(commonality "hello" "el" {string_edit_distance .true})→2(edit_distance "hello" "el" {string_edit_distance .true})→3(edit_distance "hello" "el" {use_string_edit_distance .true})→2(old documented key is ignored)git diff --checkpassed