fix: init telemetry in gateway PersistentPreRunE and add regression tests

- Call initTelemetry(cmd) in gateway's PersistentPreRunE so gateway
  subcommands send non-empty CLI telemetry (command_path, device_name, etc.).
  Cobra does not chain PersistentPreRun; adding requireGatewayProject
  in #237 replaced root's hook and skipped initTelemetry.
- Add TestInitTelemetryWhenDisabled: initTelemetry must run even when
  telemetry is disabled (singleton is still populated; header is skipped in
  PerformRequest).
- Add TestAllCommandsWithPersistentPreRunInitTelemetry: any command with
  its own PersistentPreRun(E) must call initTelemetry(cmd) so the test
  fails if a new command overrides the hook without initializing telemetry.

Made-with: Cursor

Author: leggetter

pkg/cmd/gateway.go

@@ -70,6 +70,7 @@ The gateway command group provides full access to all Event Gateway resources.`,
   # Start the MCP server for AI agent access
   hookdeck gateway mcp`,
 		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+			initTelemetry(cmd)
 			return requireGatewayProject(nil)
 		},
 	}

pkg/cmd/telemetry_test.go

@@ -85,3 +85,60 @@ func TestInitTelemetryResetBetweenCalls(t *testing.T) {
 	require.Equal(t, "device-2", tel2.DeviceName)
 	require.NotEqual(t, id1, tel2.InvocationID)
 }
+
+// TestInitTelemetryWhenDisabled verifies that initTelemetry always populates the
+// singleton (Source, CommandPath, etc.) even when telemetry is disabled. The
+// call must happen for every command; PerformRequest later skips sending the
+// header when Disabled is true.
+func TestInitTelemetryWhenDisabled(t *testing.T) {
+	hookdeck.ResetTelemetryInstanceForTesting()
+
+	Config.TelemetryDisabled = true
+	defer func() { Config.TelemetryDisabled = false }()
+
+	cmd := &cobra.Command{Use: "whoami"}
+	Config.DeviceName = "my-device"
+	initTelemetry(cmd)
+
+	tel := hookdeck.GetTelemetryInstance()
+	require.True(t, tel.Disabled)
+	require.Equal(t, "cli", tel.Source)
+	require.Equal(t, "whoami", tel.CommandPath)
+	require.Equal(t, "my-device", tel.DeviceName)
+	require.NotEmpty(t, tel.InvocationID)
+}
+
+// TestAllCommandsWithPersistentPreRunInitTelemetry is a regression test: any
+// command that defines its own PersistentPreRun or PersistentPreRunE (and thus
+// replaces the root's hook under Cobra) must call initTelemetry(cmd) so that
+// API requests get non-empty telemetry. Otherwise the header is sent with empty
+// fields (e.g. gateway before the fix).
+func TestAllCommandsWithPersistentPreRunInitTelemetry(t *testing.T) {
+	root := RootCmd()
+	var commandsWithPreRun []*cobra.Command
+	var walk func(c *cobra.Command)
+	walk = func(c *cobra.Command) {
+		if c.PersistentPreRun != nil || c.PersistentPreRunE != nil {
+			commandsWithPreRun = append(commandsWithPreRun, c)
+		}
+		for _, child := range c.Commands() {
+			walk(child)
+		}
+	}
+	walk(root)
+
+	require.NotEmpty(t, commandsWithPreRun, "expected at least root to have PersistentPreRun")
+
+	for _, cmd := range commandsWithPreRun {
+		hookdeck.ResetTelemetryInstanceForTesting()
+		if cmd.PersistentPreRunE != nil {
+			_ = cmd.PersistentPreRunE(cmd, nil)
+		} else {
+			cmd.PersistentPreRun(cmd, nil)
+		}
+		tel := hookdeck.GetTelemetryInstance()
+		require.NotEmpty(t, tel.CommandPath,
+			"command %q has PersistentPreRun(E) but did not set telemetry (CommandPath empty); it must call initTelemetry(cmd)",
+			cmd.CommandPath())
+	}
+}