Release 1.1.2

Author: Toni Lappalainen

build.gradle

@@ -5,7 +5,7 @@ plugins {
 }
 
 group = 'io.github.hirsivaja'
-version = '1.1.1'
+version = '1.1.2'
 
 repositories {
     mavenCentral()

src/main/java/com/github/hirsivaja/ip/icmp/GenericIcmpMessage.java

@@ -25,11 +25,6 @@ public static IcmpMessage decode(ByteBuffer in, IcmpType type, IcmpCode code) {
         return new GenericIcmpMessage(type, code, payload);
     }
 
-    @Override
-    public IcmpType type() {
-        return type;
-    }
-
     public byte[] rawPayload() {
         return payload.array();
     }

src/main/java/com/github/hirsivaja/ip/icmp/IcmpCode.java

@@ -6,7 +6,7 @@ public sealed interface IcmpCode permits IcmpCode.GenericIcmpCode, IcmpCodes {
 
     byte code();
 
-    public static IcmpCode fromType(IcmpType type, byte code) {
+    static IcmpCode fromType(IcmpType type, byte code) {
         for (IcmpCode identifier : IcmpCodes.values()) {
             if (identifier.type() == type && identifier.code() == code) {
                 return identifier;

src/main/java/com/github/hirsivaja/ip/icmp/IcmpType.java

@@ -4,7 +4,7 @@ public sealed interface IcmpType permits IcmpType.GenericIcmpType, IcmpTypes {
 
     byte type();
 
-    public static IcmpType fromType(byte type) {
+    static IcmpType fromType(byte type) {
         for (IcmpType identifier : IcmpTypes.values()) {
             if (identifier.type() == type) {
                 return identifier;

src/main/java/com/github/hirsivaja/ip/icmpv6/Icmpv6Code.java

@@ -4,7 +4,7 @@ public sealed interface Icmpv6Code permits Icmpv6Code.GenericIcmpv6Code, Icmpv6C
     Icmpv6Type type();
     byte code();
 
-    public static Icmpv6Code fromType(Icmpv6Type type, byte code) {
+    static Icmpv6Code fromType(Icmpv6Type type, byte code) {
         for (Icmpv6Code identifier : Icmpv6Codes.values()) {
             if (identifier.type() == type && identifier.code() == code) {
                 return identifier;
@@ -13,5 +13,5 @@ public static Icmpv6Code fromType(Icmpv6Type type, byte code) {
         return new GenericIcmpv6Code(type, code);
     }
 
-    public record GenericIcmpv6Code(Icmpv6Type type, byte code) implements Icmpv6Code {}
+    record GenericIcmpv6Code(Icmpv6Type type, byte code) implements Icmpv6Code {}
 }

src/main/java/com/github/hirsivaja/ip/icmpv6/Icmpv6Message.java

@@ -49,8 +49,8 @@ static Icmpv6Message decode(ByteBuffer in, Icmpv6Type type, Icmpv6Code code) {
             case Icmpv6Types.CERTIFICATION_PATH_SOLICITATION -> CertificationPathSolicitation.decode(in);
             case Icmpv6Types.CERTIFICATION_PATH_ADVERTISEMENT -> CertificationPathAdvertisement.decode(in);
             case Icmpv6Types.MULTICAST_ROUTER_ADVERTISEMENT -> MulticastRouterAdvertisement.decode(in, code);
-            case Icmpv6Types.MULTICAST_ROUTER_SOLICITATION -> MulticastRouterSolicitation.decode(in);
-            case Icmpv6Types.MULTICAST_ROUTER_TERMINATION -> MulticastRouterTermination.decode(in);
+            case Icmpv6Types.MULTICAST_ROUTER_SOLICITATION -> MulticastRouterSolicitation.decode();
+            case Icmpv6Types.MULTICAST_ROUTER_TERMINATION -> MulticastRouterTermination.decode();
             case Icmpv6Types.RPL -> RplControlMessage.decode(in, code);
             case Icmpv6Types.EXTENDED_ECHO_REQUEST -> ExtendedEchoRequest.decode(in);
             case Icmpv6Types.EXTENDED_ECHO_REPLY -> ExtendedEchoReply.decode(in, code);

src/main/java/com/github/hirsivaja/ip/icmpv6/Icmpv6Type.java

@@ -3,7 +3,7 @@
 public sealed interface Icmpv6Type permits Icmpv6Type.GenericIcmpv6Type, Icmpv6Types {
     byte type();
 
-    public static Icmpv6Type fromType(byte type) {
+    static Icmpv6Type fromType(byte type) {
         for (Icmpv6Type identifier : Icmpv6Types.values()) {
             if (identifier.type() == type) {
                 return identifier;
@@ -12,5 +12,5 @@ public static Icmpv6Type fromType(byte type) {
         return new GenericIcmpv6Type(type);
     }
 
-    public record GenericIcmpv6Type(byte type) implements Icmpv6Type {}
+    record GenericIcmpv6Type(byte type) implements Icmpv6Type {}
 }

src/main/java/com/github/hirsivaja/ip/icmpv6/mrd/MulticastRouterSolicitation.java

@@ -20,7 +20,7 @@ public int length() {
         return BASE_LEN;
     }
 
-    public static Icmpv6Message decode(ByteBuffer in) {
+    public static Icmpv6Message decode() {
         return new MulticastRouterSolicitation();
     }
 

src/main/java/com/github/hirsivaja/ip/icmpv6/mrd/MulticastRouterTermination.java

@@ -20,7 +20,7 @@ public int length() {
         return BASE_LEN;
     }
 
-    public static Icmpv6Message decode(ByteBuffer in) {
+    public static Icmpv6Message decode() {
         return new MulticastRouterTermination();
     }
 

src/main/java/com/github/hirsivaja/ip/icmpv6/ndp/MobilePrefixAdvertisement.java

@@ -11,9 +11,9 @@
 import java.util.List;
 
 public record MobilePrefixAdvertisement(short identifier, boolean mFlag, boolean oFlag, List<NdpOption> options) implements Icmpv6Message {
-    private final static int MO = 0xC000;
-    private final static int M = 0x8000;
-    private final static int O = 0x4000;
+    private static final int MO = 0xC000;
+    private static final int M = 0x8000;
+    private static final int O = 0x4000;
 
     @Override
     public void encode(ByteBuffer out) {
@@ -47,7 +47,7 @@ public static Icmpv6Message decode(ByteBuffer in) {
             }
             case M -> mFlag = true;
             case O -> oFlag = true;
-            default -> {}
+            default -> {/* BOTH FLAGS FALSE */}
         }
         List<NdpOption> options = new ArrayList<>();
         while(in.remaining() > 2) {