Skip to content

Commit d22b01e

Browse files
committed
test(producer): a late VFX host with a GSAP wipe catches a walk that skips hidden hosts
1 parent 49017e0 commit d22b01e

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

‎packages/core/src/runtime/vfx.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1319,7 +1319,7 @@ async function capturePreviewThenPaint(
13191319
await Promise.all(entries.map((entry) => capturePaintedHost(entry, t, seq, speculative)));
13201320
}
13211321

1322-
/** A `.hf-vfx-in` first laid out at 0×0 and then sized can stay blank in its capture until re-inserted (measured). */
1322+
/** A `.hf-vfx-in` first painted at 0×0 and then sized can stay blank in its capture until re-inserted (measured). */
13231323
function reinsertRegrownSources(): void {
13241324
for (const src of registry.flatMap(entrySources)) {
13251325
const empty = deviceSize(src.inner) === null;

‎packages/producer/src/services/vfxDeterminism.test.ts‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -578,8 +578,8 @@ describe("data-vfx-chain in the browser", () => {
578578
errors: string[],
579579
registeredStyle?: string,
580580
): Promise<void> {
581-
if (registeredStyle === undefined) await page.addScriptTag({ content: runtime });
582581
// The wrapper registers with `registeredStyle` and gets its own back before any paint.
582+
if (registeredStyle === undefined) await page.addScriptTag({ content: runtime });
583583
else
584584
await page.evaluate(
585585
(src: string, style: string) => {
@@ -710,9 +710,8 @@ describe("data-vfx-chain in the browser", () => {
710710
}, 60_000);
711711

712712
const CLEAR = [0, 0, 0, 0];
713-
// Per frame: the wrapper's style and the probe pixel, null while the host is outside its
714-
// window; then how many one-frame reports the shot makes, and the wrapper's style at page
715-
// load and at registration, and when the host starts, where they differ.
713+
// `pixel` null: the host has not started yet. The options override the wrapper's style at
714+
// load and at registration, and the host's start.
716715
it.each<
717716
[
718717
string,
@@ -761,7 +760,7 @@ describe("data-vfx-chain in the browser", () => {
761760
["", red],
762761
],
763762
0,
764-
{ hostStart: 0.02 },
763+
{ registered: "", hostStart: 0.02 },
765764
],
766765
[
767766
"is 0×0 at load and sized before the first seek: it paints on that seek",

0 commit comments

Comments
 (0)