refactor(engine): one page URL for navigation and error attribution

Author: miguel-heygen

packages/engine/src/services/frameCapture.test.ts

@@ -72,19 +72,14 @@ describe("classifyPageError", () => {
 
   it("records a syntax error and a thrown string, which carry no error stack", () => {
     const syntax = thrown("SyntaxError: Unexpected token ';'", `${server}/comp.js`, []);
-    const plain = thrown(
-      undefined,
-      `${server}/index.html`,
-      [`${server}/index.html`],
-      "plain string",
-    );
+    const plain = thrown(undefined, doc, [doc], "plain string");
     expect(classifyPageError(syntax, doc)).toBe("runtime-error:SyntaxError: Unexpected token ';'");
     expect(classifyPageError(plain, doc)).toBe("runtime-error:plain string");
   });
 
   it("records a foreign library throwing when the composition called it", () => {
     const lib = "https://cdn.example/lib.js";
-    expect(classifyPageError(thrown("TypeError: x", lib, [lib, `${server}/index.html`]), doc)).toBe(
+    expect(classifyPageError(thrown("TypeError: x", lib, [lib, doc]), doc)).toBe(
       "runtime-error:TypeError: x",
     );
   });
@@ -100,9 +95,7 @@ describe("classifyPageError", () => {
     const abort =
       "AbortError: The play() request was interrupted by a call to pause(). https://goo.gl/LdLk22";
     expect(classifyPageError(thrown("Error: widget failed", widget, [widget]), doc)).toBeNull();
-    expect(
-      classifyPageError(thrown(abort, `${server}/index.html`, [`${server}/index.html`]), doc),
-    ).toBeNull();
+    expect(classifyPageError(thrown(abort, doc, [doc]), doc)).toBeNull();
   });
 
   // initializeSession registers its listeners before the incomplete fake session makes it throw.
@@ -123,9 +116,7 @@ describe("classifyPageError", () => {
       browserConsoleBuffer: [],
     };
     await initializeSession(session as unknown as CaptureSession).catch(() => {});
-    const error = thrown("ReferenceError: gsap is not defined", `${server}/index.html`, [
-      `${server}/index.html`,
-    ]);
+    const error = thrown("ReferenceError: gsap is not defined", doc, [doc]);
     runtimeListeners.get("Runtime.exceptionThrown")?.({ exceptionDetails: error });
     runtimeListeners.get("Runtime.exceptionThrown")?.({ exceptionDetails: error });
     expect(session.pageErrors).toEqual(["runtime-error:ReferenceError: gsap is not defined"]);

packages/engine/src/services/frameCapture.ts

@@ -2235,7 +2235,7 @@ export function classifyPageError(
   const origin = new URL(documentUrl).origin;
   const frames = (details.stackTrace?.callFrames ?? []).map((frame) => frame.url);
   // Frameless: a parse error names its script; a browser API rejection names only the document.
-  const urls = frames.length > 0 ? frames : details.url === documentUrl ? [] : [details.url];
+  const urls = frames.length > 0 ? frames : [details.url].filter((url) => url !== documentUrl);
   return urls.some((url) => url?.startsWith(`${origin}/`)) ? `runtime-error:${firstLine}` : null;
 }
 
@@ -2310,16 +2310,17 @@ export async function initializeSession(session: CaptureSession): Promise<void>
     );
   });
 
+  // Navigate to the file server
+  const url = `${serverUrl}/index.html`;
+
   // Unlike the pageerror Error, this keeps the script URL of syntax errors and thrown non-errors.
   const runtimeClient = await getCdpSession(page);
   runtimeClient.on("Runtime.exceptionThrown", ({ exceptionDetails }) => {
-    const pageError = classifyPageError(exceptionDetails, `${serverUrl}/index.html`);
+    const pageError = classifyPageError(exceptionDetails, url);
     if (pageError && !session.pageErrors.includes(pageError)) session.pageErrors.push(pageError);
   });
   await runtimeClient.send("Runtime.enable");
 
-  // Navigate to the file server
-  const url = `${serverUrl}/index.html`;
   const pageNavigationTimeout =
     session.config?.pageNavigationTimeout ?? DEFAULT_CONFIG.pageNavigationTimeout;
   const initStart = Date.now();